mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Ard Biesheuvel" <ardb+git@google.com>, linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org, "Kees Cook" <kees@kernel.org>,
	"Eric Biggers" <ebiggers@kernel.org>
Subject: Re: [PATCH] lkdtm: Add case to provoke a crash in EFI runtime services
Date: Tue, 19 May 2026 17:22:01 +0200	[thread overview]
Message-ID: <6467020e-db1e-415b-9fc2-25f13760c875@app.fastmail.com> (raw)
In-Reply-To: <20260501170156.2833364-2-ardb+git@google.com>

On Fri, 1 May 2026, at 19:01, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> Add a lkdtm test case that triggers a fault during the execution of a
> EFI runtime service by passing a read-only variable as a by-ref argument
> that the firmware is supposed to update.
>
> This is useful for testing the graceful handling of faults/exception in
> EFI platform firmware, which is implemented on x86 and arm64.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  drivers/misc/lkdtm/bugs.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>

Ping?

> diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c
> index e0098f314570..3eca2ef64aff 100644
> --- a/drivers/misc/lkdtm/bugs.c
> +++ b/drivers/misc/lkdtm/bugs.c
> @@ -7,6 +7,7 @@
>   */
>  #include "lkdtm.h"
>  #include <linux/cpu.h>
> +#include <linux/efi.h>
>  #include <linux/list.h>
>  #include <linux/hrtimer.h>
>  #include <linux/sched.h>
> @@ -817,6 +818,29 @@ static noinline void lkdtm_CORRUPT_PAC(void)
>  #endif
>  }
> 
> +static void __maybe_unused lkdtm_EFI_RUNTIME_CRASH(void)
> +{
> +	static unsigned long size __ro_after_init = sizeof(efi_char16_t);
> +	efi_status_t status;
> +
> +	if (!efi.get_next_variable ||
> +	    !efi_enabled(EFI_RUNTIME_SERVICES) ||
> +	    !efi_rt_services_supported(EFI_RT_SUPPORTED_GET_NEXT_VARIABLE_NAME)) {
> +		pr_err("FAIL: EFI GetNextVariableName() is not available\n");
> +		return;
> +	}
> +
> +	/*
> +	 * Provoke a fault by asking the firmware to write to a read-only
> +	 * variable.
> +	 */
> +	status = efi.get_next_variable(&size, L"", &(efi_guid_t){});
> +
> +	if (status != EFI_ABORTED || efi_enabled(EFI_RUNTIME_SERVICES))
> +		pr_err("FAIL: EFI GetNextVariable() did not abort (%#lx)\n",
> +		       status);
> +}
> +
>  static struct crashtype crashtypes[] = {
>  	CRASHTYPE(PANIC),
>  	CRASHTYPE(PANIC_STOP_IRQOFF),
> @@ -850,6 +874,9 @@ static struct crashtype crashtypes[] = {
>  	CRASHTYPE(UNSET_SMEP),
>  	CRASHTYPE(DOUBLE_FAULT),
>  	CRASHTYPE(CORRUPT_PAC),
> +#ifdef CONFIG_EFI
> +	CRASHTYPE(EFI_RUNTIME_CRASH),
> +#endif
>  };
> 
>  struct crashtype_category bugs_crashtypes = {
> -- 
> 2.54.0.545.g6539524ca2-goog

  reply	other threads:[~2026-05-19 15:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 17:01 Ard Biesheuvel
2026-05-19 15:22 ` Ard Biesheuvel [this message]
2026-05-21 10:20 ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6467020e-db1e-415b-9fc2-25f13760c875@app.fastmail.com \
    --to=ardb@kernel.org \
    --cc=ardb+git@google.com \
    --cc=ebiggers@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®