From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7F2117BED0 for ; Tue, 24 Dec 2024 18:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735065356; cv=none; b=iJzvtccX2pAGlxEPWHowP0keL4UiMlKP6kuqCQqv2CFqT7wIWJPPGsgeJ7BXyRAOoWd/egUUuNGhedSaCrb4C8iicFbz+Jc1bk+OYcWFIhJnb0fJ2l9Lt1tTsVxub4vkOlvC7H7eJ2pjJJq0Rfs5C0Xz5AyVlbfZcoSqnxG4P8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735065356; c=relaxed/simple; bh=9FiNisxucwZIdoJgoGQTYnT3v03hfXl00vE6LZp/gqs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CXb3/1kGdfcUgsRy+XnMuMhFncjI3K0VSvh0E1+BQ+TtFiAXbtx0MVfRDzHrnjJBJJjTivjMx6zV3mQDyhT++HKl3iucJO5ESz+SAPO8FGMG+kKDSZ/45qpqC6PNbFSGmVmx6Yan/xgYVE7/WiOxuFxoCTciHPJRZ5Gtjqdc+Yk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ngO6/DPP; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ngO6/DPP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1735065352; bh=9FiNisxucwZIdoJgoGQTYnT3v03hfXl00vE6LZp/gqs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ngO6/DPPRSVCciWZ//VpwEh/4D3d+NO3iOXuexJtzpR3+Tp2NBGnBPIHnn8I04cRG qgVfYRRBqMDf2rbDJkqxHaz/7/Q9ff4HFlhQ4E1MgyUSTmrFlQiTTySYenBHFeuICg 4P+VCF6tSXy0ZjbZwCtreEbh2wozUGknF/mJEEGhjDq+XHDcKDv5ZjU3bi80NI2q0b bmx2WvCtf/mrHaz4WvULBh8oyb06bbCw/pf4dkBCXnlLmgUx1FgVjb+lLHBTCxRWFx b9UZAkXuxGG/3AV8e7J0mG+gxU/JJrQarEyig9MKGzxssX7YOChKDOlbvNM5+OjjUp BH/B3dGU4h0Mw== Received: from [192.168.1.90] (unknown [84.232.140.38]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 413BF17E15B0; Tue, 24 Dec 2024 19:35:52 +0100 (CET) Message-ID: <646893af-fea8-473f-ba1a-0980d770d81e@collabora.com> Date: Tue, 24 Dec 2024 20:35:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] drm/connector: hdmi: Validate supported_formats matches ycbcr_420_allowed To: Maxime Ripard Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20241217-bridge-conn-fmt-prio-v3-0-3ecb3c8fc06f@collabora.com> <20241217-bridge-conn-fmt-prio-v3-2-3ecb3c8fc06f@collabora.com> <20241217-positive-elephant-of-resistance-f4b0ee@houat> From: Cristian Ciocaltea Content-Language: en-US In-Reply-To: <20241217-positive-elephant-of-resistance-f4b0ee@houat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/17/24 5:25 PM, Maxime Ripard wrote: > On Tue, Dec 17, 2024 at 12:54:08AM +0200, Cristian Ciocaltea wrote: >> Ensure HDMI connector initialization fails when the presence of >> HDMI_COLORSPACE_YUV420 in the given supported_formats bitmask doesn't >> match the value of drm_connector->ycbcr_420_allowed. >> >> Suggested-by: Dmitry Baryshkov >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/gpu/drm/drm_connector.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c >> index fc35f47e2849ed6786d6223ac9c69e1c359fc648..ca7f43c8d6f1b31ef9d3a1ee05f4df930ecffac4 100644 >> --- a/drivers/gpu/drm/drm_connector.c >> +++ b/drivers/gpu/drm/drm_connector.c >> @@ -507,6 +507,9 @@ int drmm_connector_hdmi_init(struct drm_device *dev, >> if (!supported_formats || !(supported_formats & BIT(HDMI_COLORSPACE_RGB))) >> return -EINVAL; >> >> + if (connector->ycbcr_420_allowed != !!(supported_formats & BIT(HDMI_COLORSPACE_YUV420))) >> + return -EINVAL; >> + >> if (!(max_bpc == 8 || max_bpc == 10 || max_bpc == 12)) >> return -EINVAL; > > The patch looks fine to me, but we need to have unit tests to cover this case. Unit tests added in v4: https://lore.kernel.org/lkml/20241224-bridge-conn-fmt-prio-v4-4-a9ceb5671379@collabora.com/ Thanks, Cristian