From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81A2C3D6CDC for ; Wed, 3 Jun 2026 02:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780454593; cv=none; b=fq0lGBTj5gToH+jxELYrXCvAwpMBbIuX1/1PcM7MLJZE27mMTHZGKx9EwjiVzS7iFEu12RZEcfTH1Fz7Uz5hPakC8M13/BLMO3+8Do4pRbrpIg6XpbsY82PI0G4fKCsi8JgwCe4OmdE0VsFFUGdelOmrU/JiV6jZWQXTea395Eo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780454593; c=relaxed/simple; bh=dsnxwwDH2cAlvrhQteq81yhtURj5u/rS9B6dlvBH+Kw=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=Tnyt0ZrHZKo/JcUmwdpMsAPyp6AsZuQ6rrCNRoCGo88dMyyzs2o1DAKdcu+VgUozgqM9XSeJHJr+OVvt2b7MapZ4aP8KRi5baVGBpX4d7nv2YbgRl7Ham7c3uJP7pgnjUzaVcBRNrxF4zinFPzHhFR+S2SHdxm8UyzoF49p9XgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=qIUk5At9; arc=none smtp.client-ip=95.215.58.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="qIUk5At9" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780454590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yjBalMusC7z1Xgp8V8aGUlWtzrk4A/s6uSiB5E9g3wc=; b=qIUk5At9ThYG7PFryHkApvEi2uFBSRGP7kCANZeq+Zx1eZ8RHEIp0MA+9o9KGotnS18ict S56mHDOSvW+4opHm9v8BoZpxPrJvGyqtnJSx9644wWoLU9qpzkagJCGIvwtMyFwc6HQtk4 3YiFbZnN5zIKFoJcAc5lWpVLDBM4lp8= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH v3 15/19] mm/hugetlb_vmemmap: Move bootmem HVO setup to early init X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <178041489396.457517.6730523256790632908.b4-review@b4> Date: Wed, 3 Jun 2026 10:42:33 +0800 Cc: Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Madhavan Srinivasan , Michael Ellerman , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nicholas Piggin , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , "Aneesh Kumar K.V" , linuxppc-dev@lists.ozlabs.org, Mike Kravetz Content-Transfer-Encoding: quoted-printable Message-Id: <646C6366-B450-4A28-BE78-97D05562551B@linux.dev> References: <20260602101039.1867613-1-songmuchun@bytedance.com> <20260602101039.1867613-16-songmuchun@bytedance.com> <178041489396.457517.6730523256790632908.b4-review@b4> To: Mike Rapoport X-Migadu-Flow: FLOW_OUT > On Jun 2, 2026, at 23:41, Mike Rapoport wrote: >=20 > On Tue, 02 Jun 2026 18:10:35 +0800, Muchun Song = wrote: >> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c >> index ea6af85bfec1..464578ee246e 100644 >> --- a/mm/hugetlb_vmemmap.c >> +++ b/mm/hugetlb_vmemmap.c >> @@ -745,6 +745,8 @@ static bool = vmemmap_should_optimize_bootmem_page(struct huge_bootmem_page *m) >> return true; >> } >>=20 >> +static struct zone *pfn_to_zone(unsigned nid, unsigned long pfn); >> + >=20 > Can we please move the entire function rather than add a forward > declaration? Yes. Will update next version. >=20 > Other than that >=20 > Acked-by: Mike Rapoport (Microsoft) Thanks. >=20 > --=20 > Sincerely yours, > Mike. >=20