From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 131D329B8D0 for ; Fri, 30 Jan 2026 10:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769770007; cv=none; b=M2mqlFpYcWomoanoKCkMTlWFp98kICvbHQiP4c3YRM94KVvQhSWJWewEEQR0SFPM61j1YhviNxCKt80kjZdiVyxEU7wNneXJBTw5wZWhuE0MCkwWfd/tuALvse4+p1O/s4UmRNU3KNR+xH0q0tLXh3tE5koHkca5SrAbU5Lnc0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769770007; c=relaxed/simple; bh=41DxCDI9BLFfSiB8T28LzqLjk8IPwF3a9dLgM4flHpo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ug96vlopA5AVO2KI23PoBaMhBC350aw8yLtsMC5CT1C71F4DwEIT2imKLYR47g4WejFBaT0iPc17IeYv0JRqXsQ690WNzHgFhkhBar/xDuwy5Esp2Gu+Y5UbdnoHCY15xWkO9xCKG0U50Ahn3qhDBHCzGMLUyIwP3uyT/CYP7hc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Es+HWqlm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SRY8vSr3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Es+HWqlm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SRY8vSr3" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60UABpbD2992829 for ; Fri, 30 Jan 2026 10:46:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eZsEGCm6nNqyjRWqQjZl0F8JQuVVl2PSAjQwQvNXoBI=; b=Es+HWqlm+VyDDgxj o2eD0d5F94Bev3NsX1ujj3HTp09Bp14zOFDc72zC5aP0QrvmBkVCVnWX+5Tmv7IA dZEUNIT8CS9C5mBUDQXy3bluifOlCf9iremn2J4eYplhVPdr4UcrslUePfphl+yM OLQfTD3rJV2dAtDGi1NCHXIz+M0mn/3dUzmJ7eEGgcxnUpUiypGeHTDKg/idbceD Z20yAqbb8J4+ZF5Dt3R/odEbmj0yC66C8oatnjJd6nGgF4D9daEUXnDSNmciPRoD BPhvl1V/vY0mauJI1b5SqDdj3qhwQ/FfAyFwNiYyonKEuYlHxTUWDlS/ymDWUVpO XF7NVQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0db1jgh5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 10:46:45 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8946586903dso1717036d6.3 for ; Fri, 30 Jan 2026 02:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769770004; x=1770374804; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eZsEGCm6nNqyjRWqQjZl0F8JQuVVl2PSAjQwQvNXoBI=; b=SRY8vSr3KHXgOQLiEqHMBedsCDpbSsF05/m3yovDRTeT+5J0+gA/+UTCS10ugxmRCA QKAM9MGlA+fBVMVVgQH7GPvwo4rO3DkmUaXhk1HbAPD1xt+CBE0O6IoqXMBlVCMEKRbg uueU9pTg35UCnk91fyRmJuSEQV6ld/J8JwegHxUxQc4YILicBkv9b3zo953xmHXriWSS qK7r0WfNf9nDr08SD1Ch+J1crvjlTAvAvAFELfQk4nH3veVXJ5Q0LKUzD3ur8xr8dj5N pzTvHZeDHhg7r4cu+vFVDjISqIlBM9X9WLOJNB+ZTQJAdvmPo6cd2Ccl5HL7HVuSAOVW 001w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769770004; x=1770374804; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eZsEGCm6nNqyjRWqQjZl0F8JQuVVl2PSAjQwQvNXoBI=; b=eciiiXn+AvICeNmc/mPjVZ9pD32B9b9HXoDvuiMIDoOhvG1qgHRv+ok8sxlFVHnSe3 IKKOL9jqjjpy4+4kBeNS4ZYFrQdupoo+auVHifJasNDcTi7JI/XDZf/cDXAH8CbSFTXK TPmuR+M94dJB+k/wYzd+/vu26wCo4GzMXVPrPBgw6sAjMPXkC7FJDP87w8l8QfC055Zu ny1Qz+3OgscOwfBMvQWsbMT8GzseDKv9K70mM+THP3iPhWxU0veamjaDVh45cmJviNRC bpuKVtpxw10o5MOSTH1EuN0C7ATKf1HAfUf9evKhDZIiPa/ejD8/6D+x2B6ISZQYt4v/ jQ+g== X-Forwarded-Encrypted: i=1; AJvYcCUfoNbHKZi7u1J5WSjkTHk1MY+y9KHBTk03l+sm3CSCOrkrv3dKIgZ+SNhh/8lmuM48im9IUHlUDfnmjLM=@vger.kernel.org X-Gm-Message-State: AOJu0YyskP8zlNgOGJAhO0mJKl9/vCmD53W9QN5T4pUoRLd3eZeOLPyn 3rwZY6ed7PrvtBb4A2cmzsIbZ14nicJLTmgmo+hGRzRufrDyaC0LvMZiwNQGLaJ0GqjorAYPaRz xP1N9p8mzdkvCYG9zibb6V6WeKzS8BeRTaQMGWT++5/M2n2hVs8NVVSDV8JqQPE+hADg= X-Gm-Gg: AZuq6aKA3SK+HMH8oV7nSGR1erYhTQjw4nBeYsbQWjlI1YpytWhVDxzKfoYFtg7wVXw Yt8fcnCtqDcH+t6+1XPblT8J/d1MoFsd4XmGxGkGznV99gFDjImyrjnLZu+PyMUf9GU91//0UDn 9Ljl5uNiMymICUZ+wxNs9ZDLsIIAxq1hewshj01oOVMH5m7mcgt3U2yVO2Liq7U5vqZ6ofoSy+i XFm8G3gbyLYLuoVQHdFejH5BTIbGadM9fi002ZM8EF0p6dyew2C7OIKBG0iNaibh5FY0NcytsLH rDngHUvm/TTdyL4sdCOg7Nq2RI2Dx8masXckPSQBjneYVdWNOT117Yu+Lt75XuCINVESeYtQLHP ofkjIanDp5HFMZn48djMrVbhG8zF+/iIxETwQqoEL6NtB7+AjxdZwMxtSReBA6dm+dEM= X-Received: by 2002:a05:620a:31a4:b0:8c5:3892:a554 with SMTP id af79cd13be357-8c9eb257d0amr251630285a.3.1769770004497; Fri, 30 Jan 2026 02:46:44 -0800 (PST) X-Received: by 2002:a05:620a:31a4:b0:8c5:3892:a554 with SMTP id af79cd13be357-8c9eb257d0amr251627685a.3.1769770004057; Fri, 30 Jan 2026 02:46:44 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbefc6685sm396249166b.17.2026.01.30.02.46.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 02:46:43 -0800 (PST) Message-ID: <646bee0a-8b10-4fa8-9d17-030876179c02@oss.qualcomm.com> Date: Fri, 30 Jan 2026 11:46:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] soc: qcom: ice: Add explicit power-domain and clock voting calls for ICE To: Harshal Dev , Krzysztof Kozlowski , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , cros-qcom-dts-watchers@chromium.org Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260123-qcom_ice_power_and_clk_vote-v1-0-e9059776f85c@qti.qualcomm.com> <20260123-qcom_ice_power_and_clk_vote-v1-11-e9059776f85c@qti.qualcomm.com> <7da1727a-c1cd-466d-88fc-e140b2e7fe5d@kernel.org> <54bf72b6-6397-4655-9c30-680b1374400b@kernel.org> <82a6ba61-94a4-48bc-a012-d09152b32781@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <82a6ba61-94a4-48bc-a012-d09152b32781@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: eGHULJnfs-LP3LKPYIki8EyNtrjduV_o X-Proofpoint-GUID: eGHULJnfs-LP3LKPYIki8EyNtrjduV_o X-Authority-Analysis: v=2.4 cv=VMTQXtPX c=1 sm=1 tr=0 ts=697c8c15 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=CfqEwSn5MTdR7akHWEwA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDA4NyBTYWx0ZWRfX55G4STm8zfkv mjKNyHmyUXqZuHCEQ6H2qGc7BICMu2suhqMmLQxWLRNVGuAJGE3hatmcf5JF54ideUQwy3cx7cP l9eAZj9yWJvk0E0n+SulNKGBMxJYunyOQQRpzS7PtcvsT3KjpQpQW7T3WcGkZq5lvrRRf0IcCO/ kZ/IBlb1wyBfFEJJK6sptCF97Fo/+YxS/9Ol2oYOyFSh5q23kSNJxLENhOKXvTmTHHfhocAeSWz 0yNzxwCKttpBh/d30mWHRtdithGSwY81Nc1aSAdIJ4H6sCMpzj9EXHQBvPnJHrRRMOHs9ziZ19G aEzW98OAWFHEH4ttwjf5a1j2iNv0kWosJ1PrJbuCwuLjpoz4l2+9Hc3yx5Tgvz4mhu2sBFzy+rA 2X8JTHO/ZohqOCpWgL1aQ7/8ySB4Mv7zhO5JKVZypRyhzEdcKc0GM5gfLyDdnZpaCGUMuqQNOfF pUzkijCJXMvRrhiikjA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_01,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 bulkscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300087 On 1/23/26 12:12 PM, Harshal Dev wrote: > Hi Krzysztof, > > On 1/23/2026 4:27 PM, Krzysztof Kozlowski wrote: >> On 23/01/2026 09:58, Krzysztof Kozlowski wrote: >>>> >>>> return 0; >>>> @@ -584,6 +597,10 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, >>>> if (IS_ERR(engine->core_clk)) >>>> return ERR_CAST(engine->core_clk); >>>> >>>> + engine->iface_clk = devm_clk_get_enabled(dev, "iface_clk"); >>>> + if (IS_ERR(engine->iface_clk)) >>>> + return ERR_CAST(engine->iface_clk); >>> >>> And here actual breakage of ALL in-tree and out-of-tree DTS. >>> >>> NAK. >>> >>> Please read internal guideline. >> >> Internal docs are pretty scattered and messy so I failed to find this >> there, which is surprising because this was frequent feedback. Therefore >> please update Kernel Upstreaming internal page with following: >> >> With few exceptions, it is not allowed to break the ABI, by making >> bindings or driver changes, where the existing or out of tree DTS would >> fail to boot. Updating in-tree DTS does not matter here, because DTS >> goes via different branch, thus driver branch would be always broken. >> This is explicitly documented in DT rules and explained also in >> maintainer-soc profile. >> >> You need to either provide strong justification for ABI break or make >> the changes backwards compatible. If the ICE can not be powered on alone without this change (i.e. no UFS, just ICE), then please spell it out explicitly, Harshal. That makes for a valid reason to break the ABI. Plus the fact that without an OPP table, the voltage requirements cannot be guaranteed to be met > > Ack and understood. Let me write this in a way that makes it backward > compatible by using devm_clk_get_optional_enabled(). Like I explained, for > Linux distros where CONFIG_SCSI_UFS_QCOM is override set to 'y'. This > clock vote isn't really needed during probe. This is really a side-effect that we shouldn't be depending on, or even considering as a backup, since the UFS driver may change independently and stop behaving this way one day > In qcom_ice_suspend/resume(). I'll only prepare/un-prepare this clock > if it was found during probe. Clock APIs generally happily eat nullptrs Konrad