From: Hans de Goede <hansg@kernel.org>
To: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>,
"Alex Hung" <alexhung@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86/intel/hid: Add Dell Pro Rugged 10/12 tablet to VGBS DMI quirks
Date: Fri, 28 Nov 2025 11:56:21 +0100 [thread overview]
Message-ID: <6475946d-f3a6-42b6-b88a-be28556e72d2@kernel.org> (raw)
In-Reply-To: <20251127070407.656463-1-acelan.kao@canonical.com>
Hi,
On 27-Nov-25 8:04 AM, Chia-Lin Kao (AceLan) wrote:
> Dell Pro Rugged 10/12 tablets has a reliable VGBS method.
> If VGBS is not called on boot, the on-screen keyboard won't appear if the
> device is booted without a keyboard.
>
> Call VGBS on boot on thess devices to get the initial state of
> SW_TABLET_MODE in a reliable way.
>
> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Regards,
Hans
> ---
> drivers/platform/x86/intel/hid.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 9c07a7faf18f..560cc063198e 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -177,6 +177,18 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "HP Elite Dragonfly G2 Notebook PC"),
> },
> },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Dell Pro Rugged 10 Tablet RA00260"),
> + },
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Dell Pro Rugged 12 Tablet RA02260"),
> + },
> + },
> { }
> };
>
next prev parent reply other threads:[~2025-11-28 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 7:04 Chia-Lin Kao (AceLan)
2025-11-28 10:56 ` Hans de Goede [this message]
2025-11-28 11:56 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6475946d-f3a6-42b6-b88a-be28556e72d2@kernel.org \
--to=hansg@kernel.org \
--cc=acelan.kao@canonical.com \
--cc=alexhung@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®