From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932508AbdJZXIx (ORCPT ); Thu, 26 Oct 2017 19:08:53 -0400 Received: from mail-qt0-f173.google.com ([209.85.216.173]:46327 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932454AbdJZXIu (ORCPT ); Thu, 26 Oct 2017 19:08:50 -0400 X-Google-Smtp-Source: ABhQp+QhRkSrzU3R8IAgQa+6LU60XIvrC2njEov1qh/00yk7puo2s96jN3JAYmc2p7Po6SRD8Wwvug== Subject: Re: [PATCH net-next 3/9] net: dsa: fix dsa_is_normal_port helper To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn References: <20171026152259.3123-1-vivien.didelot@savoirfairelinux.com> <20171026152259.3123-4-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: <64885aa8-424a-baba-e2a7-9178d3363d73@gmail.com> Date: Thu, 26 Oct 2017 16:08:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171026152259.3123-4-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2017 08:22 AM, Vivien Didelot wrote: > In order to know if a port is of type user, dsa_is_normal_port checks > that the given port is not of type DSA nor CPU. This is not enough > because a port can be unused. > > Without the previous fix, this caused the unused mv88e6xxx ports to be > configured in normal mode. > > The ds->enabled_port_mask reports the user ports, so check this instead. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian