From: Helge Deller <deller@gmx.de>
To: Haowen Bai <baihaowen@meizu.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: fix warning comparing pointer to 0
Date: Fri, 11 Mar 2022 08:24:24 +0100 [thread overview]
Message-ID: <648cd020-a275-ea0b-e0bf-ff064dde16b0@gmx.de> (raw)
In-Reply-To: <1646967409-27868-1-git-send-email-baihaowen@meizu.com>
On 3/11/22 03:56, Haowen Bai wrote:
> Fix the following coccicheck warning:
> drivers/video/fbdev/offb.c:415:13-14: WARNING comparing pointer to 0
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/offb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index 4501e84..afdb6aa 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -412,7 +412,7 @@ static void __init offb_init_fb(const char *name,
>
> info = framebuffer_alloc(sizeof(u32) * 16, NULL);
>
> - if (info == 0) {
> + if (!info) {
> release_mem_region(res_start, res_size);
> return;
> }
prev parent reply other threads:[~2022-03-11 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 2:56 Haowen Bai
2022-03-11 7:24 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=648cd020-a275-ea0b-e0bf-ff064dde16b0@gmx.de \
--to=deller@gmx.de \
--cc=baihaowen@meizu.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®