From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3E992D592C for ; Fri, 13 Mar 2026 06:34:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773383703; cv=none; b=iY1GF7rPs06qgE+3qv5X0IxWDfFfxFtT/ahiwgldpYGFHIlHrkGHofZII8m1+FXplqgi7UCRcMeC4+NtOqOzgw/KnkiGWrShZ2kMYZbmzWC4Wi4R9gHcsqzeD8x1XDq/IcydU6jm9dmEyPE/4XCZn8kNBS37S0zsejmr55dlQik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773383703; c=relaxed/simple; bh=2va6sdFJPKAQtWF5TqnT8UQlob2M5LdSHIMSGn7Lebs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dqpoMQKunrjT9Gt/hlKfixijcXkKIukdbHSzhn3vt8dz4XkG8TLLPRgLTjhVBHEYsIyJ32znrFXiYpuoQ1/qOC52w+kgNvsd/AuNirtxcOwDHcphmgqjVzdJMZ8Q9xLe8FIeN6af8oqYt3G9eI5vKzFsQizmifEP/GbdKtrfya4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lpayoPPO; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lpayoPPO" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-35a18b65515so1034101a91.1 for ; Thu, 12 Mar 2026 23:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773383697; x=1773988497; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q/jr7J8T+jhR53vKzR5OkWAl9M6wmaMQ89KXNhbZ4Ss=; b=lpayoPPOOx738SrNj+BPEAgr+tiK/8+9oMqvPyM3dygMMrZr6f8ny/Crc87s2VDraY C3S76x3E3GgSGUjyWBTX7unRH3zMegOhb2a1SrLFRedahaL/tx2JWV8AD+CapjsjQLbK m1je4BTxsSB5w092HCgg6hFla9b09NFsGEs6WjdEVcIZD+SN5AjwDboSM5Uze7KgM2W5 2Jr+0Y0tPUi5tGJHu/QchSOp4eo4GKzSuO6M9wLI51krbrJfS1pFCN/JANV8jolYWKDC z49tMhrKS/1WJlfgqPnkHZinx0HdKaSbxyWrQvKALPDW6is4YCJkbJ7NYDSQ4+3P5iqD V0QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773383697; x=1773988497; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q/jr7J8T+jhR53vKzR5OkWAl9M6wmaMQ89KXNhbZ4Ss=; b=fHVypOVPUqvtyjV5VQqEe3axWXen9qt3pHbt1SIFdKiWmXvG25gI+yfGmqZjGZlima qyNEJIKQupnIGJtWHGcQbFOySGD/e8CkPT8qKwb6IWqdvTzpyXC8cilWz8zuN+OelDx6 voToDHuR2rZwBMcbIg5ONLCMwz6JjrOtYwEHkS4X0LbbAbwc2GVKi8byP/gjE3425b9d gP1JRAQiXQTbU5g4i3j/BE2dLviEXDEgkhMVja7V9nDIWKDoiNvOGfyALR+Y4Kz5n3WW Njokr8eAHZqedPgHeTWRsjF+8DNx/GaNFtgdMXGnUVcv1ztaoH0+B4WNnZ+YAjJd3Pdj S+/w== X-Forwarded-Encrypted: i=1; AJvYcCXVWxR+ZwJ8D5G633dHvfVYoi75pzusfiF8uE6viI2GYK9dmiQY+cmHS2rnUvmXDAIOPYpErAQAsXXcrD4=@vger.kernel.org X-Gm-Message-State: AOJu0YxLPCJGz5apXWYwR0z7+yCbyYEHxq4Zs3rfOA0D808Guq7Uq8CM FsBt03VBYgbvyLU0cKdxYLK8apu9CZaFdMCDuCLidMRpCph3eyBWpJtV X-Gm-Gg: ATEYQzy8JFn/kLKsvdEmRlFoF5Y9xSie9ri4zpA5oTxbn8yFfG0FqbNYqWp/bpfxF8V f6iPGtVUKIjaw4pqVLhWFJ2p7YEhaARWaSapJGAUCC1imU2x8rxIU4ze2Q+1qq41IDHre8aFcXv dibOc/abtDEqZKNzRPM6rDKZMux0shiM9iCngGW+4NnwPW7fdeIEWvYxXE4wl8W4lzBxxWDgjQO 3Fct/vOMypSD1kyqePohWc56nAE1Ink9u5b5LrVRCv3qvhC5NwPvU8h90QSqGHBvx2EcBcgh7Mx WKpElxvrE8MIlItKRNWd3476FJcy5jTiWbcr2/PHJ1VCO4ztwhQq7za+7HLmAcTl/ytvEBzFbTT o7LTCrqzQGO8DeqCL1VdF1Bu7GjQ6Y4UYpmOpJXHmC2ny3feyx2kxavADcUY3ea8NDw+dX4Cb1p e86J6QlKMPn3VzhU1DArwi1wQEMnLCLhICNd839iYMY5WMD0s/DwoSRxE= X-Received: by 2002:a17:90b:5185:b0:359:8ed3:8a65 with SMTP id 98e67ed59e1d1-35a22113798mr1985658a91.34.1773383697493; Thu, 12 Mar 2026 23:34:57 -0700 (PDT) Received: from [192.168.1.5] ([27.7.215.222]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35a07f0a365sm6999155a91.13.2026.03.12.23.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 23:34:57 -0700 (PDT) Message-ID: <648da83c-79c5-4936-939d-690e7af1f95e@gmail.com> Date: Fri, 13 Mar 2026 12:04:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/5] dt-bindings: usb: generic-ohci: add AT91RM9200 OHCI binding support To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Claudiu Beznea , Herve Codina , Nicolas Ferre , Alexandre Belloni , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260307-atmel-usb-v3-0-3dc48fe772be@gmail.com> <20260307-atmel-usb-v3-2-3dc48fe772be@gmail.com> <20260308-camouflaged-sage-warthog-fdbb7d@quoll> <1d49a4f4-8694-470f-82e2-6021772fc821@kernel.org> Content-Language: en-US From: Charan Pedumuru In-Reply-To: <1d49a4f4-8694-470f-82e2-6021772fc821@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08-03-2026 14:58, Krzysztof Kozlowski wrote: > On 08/03/2026 10:23, Krzysztof Kozlowski wrote: >> On Sat, Mar 07, 2026 at 09:16:19AM +0000, Charan Pedumuru wrote: >>> Add binding support for the Atmel AT91RM9200 OHCI USB host controller >>> to the generic OHCI schema. >>> >>> Signed-off-by: Charan Pedumuru > > Also: > > A nit, subject: drop second/last, redundant "binding support". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > And you cannot add support for bindings. The DT schema or some kernel > Makefile gave that support, not this file. Okay, I will change that. > > >>> --- >>> .../devicetree/bindings/usb/generic-ohci.yaml | 33 ++++++++++++++++++++++ >>> 1 file changed, 33 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> index 961cbf85eeb5..a8a94b9c1fee 100644 >>> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> @@ -55,6 +55,7 @@ properties: >>> - ti,ohci-omap3 >>> - items: >>> - enum: >>> + - atmel,at91rm9200-ohci >>> - cavium,octeon-6335-ohci >>> - nintendo,hollywood-usb-ohci >>> - nxp,ohci-nxp >>> @@ -137,6 +138,16 @@ properties: >>> The associated ISP1301 device. Necessary for the UDC controller for >>> connecting to the USB physical layer. >>> >>> + atmel,vbus-gpio: >> >> gpio is deprecated. All bindings use gpios. Also, pins do not use vendor >> prefixes. >> >> >>> + description: GPIO used to control or sense the USB VBUS power. >>> + minItems: 1 >>> + maxItems: 3 >> >> Why is this flexible? There is only one VBUS, no? Which pin is it >> exactly on this device? >> >>> + >>> + atmel,oc-gpio: >>> + description: GPIO used to signal USB overcurrent condition. >>> + minItems: 1 >>> + maxItems: 3 >> >> Same question here - how is the pin called in the schematics? >> >>> + >>> required: >>> - compatible >>> - reg >>> @@ -144,6 +155,28 @@ required: >>> >>> allOf: >>> - $ref: usb-hcd.yaml >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + const: atmel,at91rm9200-ohci >>> + then: >>> + properties: >>> + clock-names: >>> + items: >>> + - const: ohci_clk >>> + - const: hclk >>> + - const: uhpck >>> + >>> + required: >>> + - clocks >>> + - clock-names >> >> There is already if:then:else covering clocks, so this makes multiple >> clauses being applied to same device. That's not really readable. >> Unfortunately that's a bit of a mess from existing binding. This can be >> solved by moving this to separate schema, especially that you want to >> add some specific properties to this device. > > I guess Rob was fine with this, so let's keep it in this file. Yes, it should be defined here as the fallback compatible is already defined in this existing YAML. > > Best regards, > Krzysztof -- Best Regards, Charan.