From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755340AbdLTOlT (ORCPT ); Wed, 20 Dec 2017 09:41:19 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:44070 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754664AbdLTOlS (ORCPT ); Wed, 20 Dec 2017 09:41:18 -0500 X-Google-Smtp-Source: ACJfBotjf8mWqd80INYgIEIAA4H32tMpCBY2Ohb+2QBV4MS3TTeOR1+JNT2RLzyb9FIGPTJSZ2/SLw== Subject: Re: [PATCH] kvm/vmx: Use local vmx variable in vmx_get_msr() To: Borislav Petkov , KVM Cc: LKML , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <20171220115028.3009-1-bp@alien8.de> From: Paolo Bonzini Message-ID: <648fd3fc-90ee-ff5b-48ee-288f318711f2@redhat.com> Date: Wed, 20 Dec 2017 15:41:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171220115028.3009-1-bp@alien8.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/12/2017 12:50, Borislav Petkov wrote: > From: Borislav Petkov > > ... just like in vmx_set_msr(). > > No functionality change. > > Signed-off-by: Borislav Petkov > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > --- > arch/x86/kvm/vmx.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 023afa0c8887..58be7915da81 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -3249,6 +3249,7 @@ static inline bool vmx_feature_control_msr_valid(struct kvm_vcpu *vcpu, > */ > static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > { > + struct vcpu_vmx *vmx = to_vmx(vcpu); > struct shared_msr_entry *msr; > > switch (msr_info->index) { > @@ -3260,8 +3261,8 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > msr_info->data = vmcs_readl(GUEST_GS_BASE); > break; > case MSR_KERNEL_GS_BASE: > - vmx_load_host_state(to_vmx(vcpu)); > - msr_info->data = to_vmx(vcpu)->msr_guest_kernel_gs_base; > + vmx_load_host_state(vmx); > + msr_info->data = vmx->msr_guest_kernel_gs_base; > break; > #endif > case MSR_EFER: > @@ -3287,13 +3288,13 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > break; > case MSR_IA32_MCG_EXT_CTL: > if (!msr_info->host_initiated && > - !(to_vmx(vcpu)->msr_ia32_feature_control & > + !(vmx->msr_ia32_feature_control & > FEATURE_CONTROL_LMCE)) > return 1; > msr_info->data = vcpu->arch.mcg_ext_ctl; > break; > case MSR_IA32_FEATURE_CONTROL: > - msr_info->data = to_vmx(vcpu)->msr_ia32_feature_control; > + msr_info->data = vmx->msr_ia32_feature_control; > break; > case MSR_IA32_VMX_BASIC ... MSR_IA32_VMX_VMFUNC: > if (!nested_vmx_allowed(vcpu)) > @@ -3310,7 +3311,7 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > return 1; > /* Otherwise falls through */ > default: > - msr = find_msr_entry(to_vmx(vcpu), msr_info->index); > + msr = find_msr_entry(vmx, msr_info->index); > if (msr) { > msr_info->data = msr->data; > break; > Queued, thanks. Paolo