mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qianfeng Rong <rongqianfeng@vivo.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	"open list:CPU FREQUENCY SCALING FRAMEWORK"
	<linux-pm@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] cpufreq: powernow: Use int type to store negative error codes
Date: Wed, 3 Sep 2025 14:50:36 +0800	[thread overview]
Message-ID: <6492c8cd-715f-4fad-8286-ffc1b4ea930c@vivo.com> (raw)
In-Reply-To: <20250903041447.6t7q5ddoqwm3og4d@vireshk-i7>


在 2025/9/3 12:14, Viresh Kumar 写道:
> $Subject is incorrect.
>
> On 02-09-25, 19:45, Qianfeng Rong wrote:
>> In powernow_decode_bios(), the 'ret' variable stores either negative error
>> codes or zero returned by get_ranges(), so it needs to be changed to int
>> type.
> You don't need to mention this now. You are making a different change.


Okay, since this patch is no longer part of this series, I will send a
patch for thismodification separately later, thank you.


>
>> However, since the 'ret' variable is only used once and can be
>> simplified to 'return get_ranges()', it is better to remove the 'ret'
>> variable.
>>
>> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
>>   drivers/cpufreq/powernow-k7.c | 4 +---
> There should be a `---` line in between these two statements, you have
> corrupted your patch somehow.
>
Ah this is my bad.


  reply	other threads:[~2025-09-03  6:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 11:45 [PATCH v3 0/3] cpufreq: " Qianfeng Rong
2025-09-02 11:45 ` [PATCH v3 1/3] " Qianfeng Rong
2025-09-03  4:12   ` Viresh Kumar
2025-09-02 11:45 ` [PATCH v3 2/3] cpufreq: powernow: " Qianfeng Rong
2025-09-03  4:14   ` Viresh Kumar
2025-09-03  6:50     ` Qianfeng Rong [this message]
2025-09-02 11:45 ` [PATCH v3 3/3] cpufreq: speedstep-lib: " Qianfeng Rong
2025-09-03  4:13   ` Viresh Kumar
2025-09-05 18:59     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6492c8cd-715f-4fad-8286-ffc1b4ea930c@vivo.com \
    --to=rongqianfeng@vivo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®