From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 487E7C7618E for ; Fri, 21 Apr 2023 18:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233104AbjDUS2j (ORCPT ); Fri, 21 Apr 2023 14:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232989AbjDUS2h (ORCPT ); Fri, 21 Apr 2023 14:28:37 -0400 Received: from sender3-op-o18.zoho.com (sender3-op-o18.zoho.com [136.143.184.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 223111BD5; Fri, 21 Apr 2023 11:28:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682101673; cv=none; d=zohomail.com; s=zohoarc; b=SaSBoPob1vx8UxWGw/1V+TbNRkGJAsK90tRye9/VlpgU8VwLnDSHghVoWUYgAjhPjoRrCWPMCItu6Twjq/fMouX8cle3IP85FsAzQ+fuTOMJmV5hyfaI60KAaEpIB/vcn4xbhatpIi6wyGmnthH1/wbL4H8s7U2zI4yryNVrGJw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682101673; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=HhtGCpgs8VG3ou8855pH8L7tkz77AnXTHtobCoUAuVM=; b=jDUZmxX2h5DWOd56WLqqY9Owk6FnqPIR/pjpPBoRhXGffhpEG2g6jacEeok7CPfMWcXKqXOzA3fnFRfr7ixvriIPCROSr12kBjLl+wwxcdmvK4iU4832VvBUlD6ZpN+GV/UISRD/tKMd2OnKwmjglhADyikmXLq165b5dpL6p0U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1682101673; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=HhtGCpgs8VG3ou8855pH8L7tkz77AnXTHtobCoUAuVM=; b=Y4ageSokWBom/G2ZCmFb/b81B/hbHdFJvx36UnHpALK+9EHjrIBm1URAAg1Ra1hW zPny3BfiOWOHfbi26F2qoXjgHI4nSL9KeR0quy6dEeAEPYHP63eaiDKdgtiimB8c9Tv gRdrOTcPG0Ix59uu3nHkY8IwbIQc9FTHmFcxDIAc= Received: from [10.10.10.3] (149.91.1.15 [149.91.1.15]) by mx.zohomail.com with SMTPS id 1682101672038904.708571478262; Fri, 21 Apr 2023 11:27:52 -0700 (PDT) Message-ID: <6493c52f-247c-c9c0-8352-4b312b7e67e4@arinc9.com> Date: Fri, 21 Apr 2023 21:27:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH net-next 02/22] net: dsa: mt7530: use p5_interface_select as data type for p5_intf_sel Content-Language: en-US To: Daniel Golle Cc: Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Richard van Schagen , Richard van Schagen , Frank Wunderlich , erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230421143648.87889-1-arinc.unal@arinc9.com> <20230421143648.87889-3-arinc.unal@arinc9.com> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.04.2023 19:23, Daniel Golle wrote: > On Fri, Apr 21, 2023 at 05:36:28PM +0300, arinc9.unal@gmail.com wrote: >> From: Arınç ÜNAL >> >> Use the p5_interface_select enumeration as the data type for the >> p5_intf_sel field. This ensures p5_intf_sel can only take the values >> defined in the p5_interface_select enumeration. >> >> Signed-off-by: Arınç ÜNAL >> --- >> drivers/net/dsa/mt7530.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h >> index 845f5dd16d83..703f8a528317 100644 >> --- a/drivers/net/dsa/mt7530.h >> +++ b/drivers/net/dsa/mt7530.h >> @@ -674,13 +674,13 @@ struct mt7530_port { >> }; >> >> /* Port 5 interface select definitions */ >> -enum p5_interface_select { >> - P5_DISABLED = 0, >> +typedef enum { > > We usually avoid adding typedef in kernel code. If the purpose is > just to be more verbose in the struct definition, you can as well > also just use 'enum p5_interface_select as type in the struct. > >> + P5_DISABLED, >> P5_INTF_SEL_PHY_P0, >> P5_INTF_SEL_PHY_P4, >> P5_INTF_SEL_GMAC5, >> P5_INTF_SEL_GMAC5_SGMII, >> -}; >> +} p5_interface_select; >> >> struct mt7530_priv; >> >> @@ -768,7 +768,7 @@ struct mt7530_priv { >> bool mcm; >> phy_interface_t p6_interface; >> phy_interface_t p5_interface; >> - unsigned int p5_intf_sel; >> + p5_interface_select p5_intf_sel; > > enum p5_interface_select p5_intf_sel; Will do, thanks. Arınç