mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gerhard Wiesinger <lists@wiesinger.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
	arm@lists.fedoraproject.org,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>, LKML <linux-kernel@vger.kernel.org>,
	filbar@centrum.cz
Subject: Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA
Date: Sat, 20 Jun 2020 21:37:04 +0200	[thread overview]
Message-ID: <6495b781-03a1-c655-90b2-71fe984ef02f@wiesinger.com> (raw)
In-Reply-To: <12ed4a27-7773-98c4-c8ba-f9b0d53a5b5f@gmail.com>

Hello Florian,

On 20.06.2020 21:13, Florian Fainelli wrote:
> Hi,
>
> On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote:
> Can you share your network configuration again with me? 

Find the network config below.


>> # OK: Last good known version (booting that version is also ok)
>> Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
>> armv7l armv7l armv7l GNU/Linux
> OK, I suspect what has changed is this commit:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8fab459e69abfd04a66d76423d18ba853fced4ab
>
> which, if I remember your configuration correctly means that you now
> have proper DSA interfaces and so all of the wan, lan1-lan4 interfaces
> can now run a proper networking stack unlike before where you had to do
> this via the DSA master network device (eth0). This also means that you
> should run your DHCP server/client on the bridge master network device now.

Yes, config should be a proper DSA config, see also below. IP config is 
only on brlan and brwan.

Do the changes need a config change?
e.g. net: dsa: b53: Ensure the default VID is untagged
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/dsa/b53?id=d965a5432d4c3e6b9c3d2bc1d4a800013bbf76f6


Thnx.


Ciao,
Gerhard

Config:

brctl show
bridge name     bridge id               STP enabled     interfaces
brlan           8000.AAAAAAAAAAAA       no              lan.101
brlansw         8000.BBBBBBBBBBBB       no              lan1
                                                         lan2
                                                         lan3
                                                         lan4
brwan           8000.CCCCCCCCCCCC       no              wan.102
brwansw         8000.DDDDDDDDDDDD       no              wan

================================================================================

= /etc/systemd/network/30-autogen-eth0.network
================================================================================
[Match]
Name=eth0

[Network]
VLAN=lan.101
VLAN=wan.102
================================================================================
= /etc/systemd/network/40-autogen-lan.101.netdev
================================================================================
[NetDev]
Name=lan.101
Kind=vlan

[VLAN]
Id=101
================================================================================
= /etc/systemd/network/40-autogen-wan.102.netdev
================================================================================
[NetDev]
Name=wan.102
Kind=vlan

[VLAN]
Id=102
================================================================================
= /etc/systemd/network/50-autogen-brlan.netdev
================================================================================
[NetDev]
Name=brlan
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=false
STP=false
================================================================================
= /etc/systemd/network/50-autogen-brlansw.netdev
================================================================================
[NetDev]
Name=brlansw
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=true
STP=false
================================================================================
= /etc/systemd/network/50-autogen-brwan.netdev
================================================================================
[NetDev]
Name=brwan
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=false
STP=false
================================================================================
= /etc/systemd/network/50-autogen-brwansw.netdev
================================================================================
[NetDev]
Name=brwansw
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=true
STP=false
================================================================================
= /etc/systemd/network/60-autogen-brlan-lan.101.network
================================================================================
[Match]
Name=lan.101

[Network]
Bridge=brlan
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan1.network
================================================================================
[Match]
Name=lan1

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan2.network
================================================================================
[Match]
Name=lan2

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan3.network
================================================================================
[Match]
Name=lan3

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan4.network
================================================================================
[Match]
Name=lan4

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brwansw-wan.102.network
================================================================================
[Match]
Name=wan.102

[Network]
Bridge=brwansw
================================================================================
= /etc/systemd/network/60-autogen-brwansw-wan.network
================================================================================
[Match]
Name=wan

[Network]
Bridge=brwansw

[BridgeVLAN]
VLAN=102
EgressUntagged=102
PVID=102
================================================================================
= /etc/systemd/network/60-autogen-brwan-wan.102.network
================================================================================
[Match]
Name=wan.102

[Network]
Bridge=brwan
================================================================================
= /etc/systemd/network/61-autogen-brlan.network
================================================================================
[Match]
Name=brlan

[Network]
Address=192.168.39.2/24
Gateway=192.168.39.1
DNS=192.168.39.1
Domains=mydomain
================================================================================
= /etc/systemd/network/61-autogen-brwan.network
================================================================================
[Match]
Name=brwan

[Network]
Address=192.168.1.1/24


  reply	other threads:[~2020-06-20 19:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-20 17:39 Gerhard Wiesinger
2020-06-20 19:13 ` Florian Fainelli
2020-06-20 19:37   ` Gerhard Wiesinger [this message]
2020-06-21 21:10     ` Florian Fainelli
2020-06-25 23:23 ` [fedora-arm] " Peter Robinson
2020-06-26  4:41   ` Florian Fainelli
2020-06-26  9:09     ` Peter Robinson
2020-06-26 15:46       ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6495b781-03a1-c655-90b2-71fe984ef02f@wiesinger.com \
    --to=lists@wiesinger.com \
    --cc=arm@lists.fedoraproject.org \
    --cc=f.fainelli@gmail.com \
    --cc=filbar@centrum.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®