From: Ira Weiny <ira.weiny@intel.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>, <ira.weiny@intel.com>,
<dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
<dave.jiang@intel.com>, <oohall@gmail.com>,
<aneesh.kumar@linux.ibm.com>
Cc: <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: Re: [PATCH] libnvdimm/of_pmem: Add check and kfree for kstrdup
Date: Fri, 23 Jun 2023 10:19:06 -0700 [thread overview]
Message-ID: <6495d40a1974c_4ccfa29497@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20230622143800.31779-1-jiasheng@iscas.ac.cn>
Jiasheng Jiang wrote:
> On Wed, Jun 21, 2023 at 00:04:36 +0800, Ira Weiny wrote:
> > Ira Weiny wrote:
> >> Jiasheng Jiang wrote:
[snip]
> >>
> >> Nice catch!
> >>
> >> However, this free needs to happen in of_pmem_region_remove() as well.
> >
> > Looks like the mail from my phone had html in it. Sorry for that.
> >
> > This would be better with devm_kstrdup() and then we don't have to worry
> > about the kfree at all.
>
> Looks good.
> I have submitted a new patch "libnvdimm/of_pmem: Replace kstrdup with devm_kstrdup and add check".
> Since the titie has been modified, I did not submitted a v2.
Ah ok... But looks like we will need a v3. See the other email.
Thanks again for trying to fix this,
Ira
next prev parent reply other threads:[~2023-06-23 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 14:38 Jiasheng Jiang
2023-06-23 17:19 ` Ira Weiny [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-19 3:36 Jiasheng Jiang
2023-06-20 13:43 ` Ira Weiny
2023-06-20 16:04 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6495d40a1974c_4ccfa29497@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=oohall@gmail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®