From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbeC2Oo4 convert rfc822-to-8bit (ORCPT ); Thu, 29 Mar 2018 10:44:56 -0400 Received: from mail.phycard.de ([217.6.246.34]:56446 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbeC2Ooy (ORCPT ); Thu, 29 Mar 2018 10:44:54 -0400 Subject: Re: [PATCH] mfd: dt-bindings: Add PMIC reset property To: Rob Herring Cc: mark.rutland@arm.com, heiko@sntech.de, w.egorov@phytec.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1521111530-39920-1-git-send-email-d.schultz@phytec.de> <20180318125207.5dotrxc37owbeyyb@rob-hp-laptop> From: Daniel Schultz Message-ID: <64961d3c-3037-d141-ee3c-c1a71ac275db@phytec.de> Date: Thu, 29 Mar 2018 16:46:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180318125207.5dotrxc37owbeyyb@rob-hp-laptop> X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 29.03.2018 16:44:52, Serialize by Router on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 29.03.2018 16:44:53 X-TNEFEvaluated: 1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 03/18/2018 01:52 PM, Rob Herring wrote: > On Thu, Mar 15, 2018 at 11:58:50AM +0100, Daniel Schultz wrote: >> Add documentation about a new rk808 devicetree property, which can >> enable resets by the PMIC. > > The subject needs to be more specific that this is for Rockchip PMIC. > >> >> Signed-off-by: Daniel Schultz >> --- >> Documentation/devicetree/bindings/mfd/rk808.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt >> index 91b6522..fa1a30f 100644 >> --- a/Documentation/devicetree/bindings/mfd/rk808.txt >> +++ b/Documentation/devicetree/bindings/mfd/rk808.txt >> @@ -20,6 +20,8 @@ Optional properties: >> default output clock name >> - rockchip,system-power-controller: Telling whether or not this pmic is controlling >> the system power. >> +- rockchip,system-reset-controller: Telling whether or not this pmic is controlling >> + the system reset. > > Would you ever really have power and reset controlled by different > things? IOW, why do we need 2 properties? > The existing property enables the shutdown function and since the preferred way for resetting the system is the soft reset (control and reset module), rockchip wishes to have an extra property. -- Mit freundlichen Grüßen, With best regards, Daniel Schultz