From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57AD9284690 for ; Tue, 27 Jan 2026 13:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769520113; cv=none; b=S5Lt1jgtTKqcR4QEPefJtvilVNujQn2eYNCEvMAFJkl/VdcyY4UQmubMTGCGLx4eyMSihdmAQkpLlS/xiCTJX8tZiPA5mEMPhwarTwVzgQTpbE3/C1s2wGRbtP+pQfAJHHTk+VK+ICDZLwYpK4gXbjEvDfWlKIf9J7xVNDRrcLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769520113; c=relaxed/simple; bh=hxE8DgeXBHRE1gGLEQJUpLHZc2gKWvTHb81dLyry0kk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M4ckaaqoPxHOHk4APMaAXw8gtx5WhH0kyCRhOFybS1Z72eBNUdjxplxMeUMrep+j66gAr0u7heZpb+A1OTczY+oxWBOF/a0ebSu2tNsvFwrfy4hdIh30dgsLnl6mXr6NBjrT2VpablMi8MWrh7mAnYmImL0yRGBhZQKD+uVGap8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q8nn6Qtk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ctzc8Kln; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q8nn6Qtk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ctzc8Kln" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60RA79uV786605 for ; Tue, 27 Jan 2026 13:21:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AXdYhC+4OLkMnLH64qCoEJNjy817DN2szJ1t4wD7K0c=; b=Q8nn6QtkTqTxIPKP eXgnw1l1BeLaq5566gR6OzICQ2LMYWtYGus8/tJEqoj8BNJAywomNB3rt1VWj3/6 nVb7aUQ96XeGNZOw3WvtaWDesCullWIUOFqgDCn7vZ2q70JZ3CDztocu/fOYqjfC Ql94wx1AfdHNhAkaWshHVunUFiGh2uBfaonS7Q9b2BYO0OTKrcUJWSvUtU3k0xe+ XNhCYtn0i/gV63muq6nvekHzC4raTVSf6iNjYjHN16u4dsYsFDqavtGngcp7UP+A qn67p1JVPWrDbQ+jj0FqN4gF2jDbqbrAhyDDZFvMst7TFGtSv4a1EF/Lpppz4BL5 D+kLIw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxg93jp3g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 13:21:51 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c6b48c08deso172183485a.1 for ; Tue, 27 Jan 2026 05:21:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769520111; x=1770124911; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AXdYhC+4OLkMnLH64qCoEJNjy817DN2szJ1t4wD7K0c=; b=ctzc8KlnP2yOyTh50cvDDBrDx9ImpR9koent64tjMpSTQvw//C8Sd1nqEjLy50sUYF EM65Ns7RXqjNCS7cOfyBVIYbxfbe0UQzhgXTE0JOBVhxJ0wOdS7ziLlUrViWao0YM72X U2hzoaiPNYkX5wMOwoA6AP7AySez4Os2MScVxoU2VDbfPxGAbGeQSRbGl++g/2mzEbWc KgxTAgvd4nE6Ui2pRxLQKI8Vh2w3WGPaT7cp8iFcPBegOrwiH5kjcDokCq6aprEXmuxp I/+MjBpiNE9gnXLh4pvmJbdxrqjoPBME4RPVGUKKuzV+Y6kiEU/vetD/emQ0ALeEOa8W cnjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769520111; x=1770124911; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AXdYhC+4OLkMnLH64qCoEJNjy817DN2szJ1t4wD7K0c=; b=v7eLyxiye6V/DV5TIbgQZNLSBRUQM1JILPfUlvSO+Rs4BkeaQaucAGzNLEiGRPeuYh TVjUuEJy3tL3DyXr7OaW+fBWOKxGEzWQ9RJhfpqlNDEsnp8tos0vHOrpu4bJKrKHJib2 Em4XoxxVsZ1emcazg9/eNJYtVxmY5R62UyHeu6JRvCW2knwymlvFBafnqyosfKZ/sdX3 phu6zR4N75bLGPyZo4NlEEEBzXBjPGTtchaM2CYVT7HQnDTzu0Dvs5k6VqJbZ+zN2e28 z8EMO1isELq2b+2CRapBpqykNWEVUW2DiaoGK9oMfQHgk+sqREY+ZtkXj5YJUwX6TNfs z5Aw== X-Forwarded-Encrypted: i=1; AJvYcCWTbIZmwPerTvgtWsyvJQfc7KNrzR0u0yAhb0FJGnKgDqad8s5uEfj4RFb2VfO6/bgJwgEaDnqCJ565j0U=@vger.kernel.org X-Gm-Message-State: AOJu0YyzcFsg662kfTmlGwiUFri+Z//FPqzPP5gFGhwF0gjyZsKzUjA6 1kOdaYNLbhNXy0qlcVXy85GfZQcNo7RTKyizryEfqDcr7r9PDGRy6/GcbIiWAH+v7Z/x6hqHONf NPhi3EbJiyD6tau4Ux4PL04+S6nOYIdnNzhpmBpfvTNmaG155eHQQCKHnHJyukRCd+wg= X-Gm-Gg: AZuq6aIFEuYg/FMoDY3M/mrLhfAhf3UYpF8A2w0TFvi/swFOpJ+G54zhyA4lvJXCa/U g4b4kgf4c7IXFABybQfhy4NZUi3vwVBipYktJcIkoGeAz79/bVrhwb1Chnh2m/DksM8oAREMKmp DF8aCaIFmZDWAbTQefH/crBmzmd6F+1lV4F20LFRn0v56URl6NA5u1gKTwNJPaDlg53DeI3uXb3 ruvZ/9byqd7LEb3O6oX49rjrFU8mH19vKmdVwUER+pPJjbN2LLsG+1SQOdxai5ILJ35QmaFvxtj sKpMdfBTYBmcmPSs0hO6Fng6K/RZbnwnHHA3Fj3VcnVFVgFxcJFrC9GbQBb3Y57P0XnDz2h0WMR nu0fniErY20g6lw6M1vR/fvRlTwCo1nyXAwGCh0Ur574/WRprywwteyc45+8NZ03pees= X-Received: by 2002:a05:620a:2802:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8c70b73f90cmr157678085a.0.1769520110866; Tue, 27 Jan 2026 05:21:50 -0800 (PST) X-Received: by 2002:a05:620a:2802:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8c70b73f90cmr157674885a.0.1769520110413; Tue, 27 Jan 2026 05:21:50 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b885b3dad3asm807868666b.12.2026.01.27.05.21.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 05:21:49 -0800 (PST) Message-ID: <64961e27-e316-47d1-8ab4-c4868754adb6@oss.qualcomm.com> Date: Tue, 27 Jan 2026 14:21:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] spi: geni-qcom: Add target abort support To: Praveen Talari , Mark Brown , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260122151008.2149252-1-praveen.talari@oss.qualcomm.com> <20260122151008.2149252-4-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260122151008.2149252-4-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEwOSBTYWx0ZWRfX3uD8qJHuKBJN qF2ZPYn+XLFf/znL/CPZKL+h0d41e4gRVFplW9ptJ+BtVs2NjhKrGXdCq6g6n4BhhzfpXXdgqTl uFbh4zt3sbMZgi8HeMPcoDVE3WRfz6xDhpdrtvhrCvrtJ5nzQQRbaz6bjVZZIt1vbM4okvj3Nrd WqEoI09C1bvvB52c2ClcrZLPQEVJb8+6V8DXtKKerP4w4dNgBbv8YtQUyTTU1RnmFT/2Jjyq36t a9kYmd201brLr/ioXaotPOgS0hPFGKFxtTz5a6qOKh1sJEdrwr7hbZmxTFIHTmg/Ak500H2qFNL jpXi1gtiptYN7AwfO0+GoYjpvhx2ApJgc1PLKa5R8RE/wdjVlx4YtbBdqevV+S3QsQ6FlpTtfsy qDVgzjIj5Os05gjfnPATm+cIpFtzHt/QWq5XxXkHFZHRSCsVt86VZQKVITSgwxGSHIEbhMgLbaD xvMmP+k4kwjzCAKh6Ug== X-Authority-Analysis: v=2.4 cv=Uc1ciaSN c=1 sm=1 tr=0 ts=6978bbef cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KiRDxWFFE5j6wAypeYgA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: BxV61TEOsuc99MeHkc3jL7p9WZDdAKca X-Proofpoint-GUID: BxV61TEOsuc99MeHkc3jL7p9WZDdAKca X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_02,2026-01-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270109 On 1/22/26 4:10 PM, Praveen Talari wrote: > SPI target mode currently lacks a mechanism to gracefully abort ongoing > transfers when the client or core needs to cancel active transactions. > > Implement spi_geni_target_abort() to handle aborting SPI target > operations when the client and core want to cancel ongoing transfers. > This provides a mechanism for graceful termination of active SPI > transactions in target mode. > > Signed-off-by: Praveen Talari > --- > drivers/spi/spi-geni-qcom.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c > index e5320e2fb834..231fd31de048 100644 > --- a/drivers/spi/spi-geni-qcom.c > +++ b/drivers/spi/spi-geni-qcom.c > @@ -1009,6 +1009,17 @@ static irqreturn_t geni_spi_isr(int irq, void *data) > return IRQ_HANDLED; > } > > +static int spi_geni_target_abort(struct spi_controller *spi) > +{ > + if (!spi->cur_msg) > + return 0; > + > + handle_se_timeout(spi, spi->cur_msg); I can't help but notice this function never even dereferences this argument Konrad