mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Diederik de Haas <didi.debian@cknow.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add reset button to NanoPi R5S
Date: Wed, 9 Jul 2025 13:05:10 +0200	[thread overview]
Message-ID: <649824ea-a420-437e-ace1-2f079235c604@kernel.org> (raw)
In-Reply-To: <20250709105715.119771-1-didi.debian@cknow.org>

On 09/07/2025 12:57, Diederik de Haas wrote:
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&gpio4_a0_k1>;
> +		pinctrl-names = "default";
> +
> +		button-reset {
> +			debounce-interval = <50>;
> +			gpios = <&gpio4 RK_PA0 GPIO_ACTIVE_LOW>;
> +			label = "RESET";
> +			linux,code = <KEY_RESTART>;
> +		};
> +	};
> +
>  	gpio-leds {
>  		compatible = "gpio-leds";
>  		pinctrl-names = "default";
> @@ -127,6 +140,12 @@ eth_phy0_reset_pin: eth-phy0-reset-pin {
>  		};
>  	};
>  
> +	gpio-keys {
> +		gpio4_a0_k1: gpio4-a0-k1 {

Are you sure that this passes checks?

Best regards,
Krzysztof

  reply	other threads:[~2025-07-09 11:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09 10:57 Diederik de Haas
2025-07-09 11:05 ` Krzysztof Kozlowski [this message]
2025-07-09 11:17   ` Diederik de Haas
2025-07-09 14:18     ` Krzysztof Kozlowski
2025-07-09 15:11       ` Heiko Stübner
2025-07-09 16:47       ` Diederik de Haas
2025-07-09 19:49         ` Heiko Stübner
2025-07-10  9:10           ` Diederik de Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=649824ea-a420-437e-ace1-2f079235c604@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=didi.debian@cknow.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®