From: "Peter Senna" <peter.senna@collabora.co.uk>
To: "Joe Perches" <joe@perches.com>
Cc: sergei.shtylyov@cogentembedded.com,
"Peter Senna Tschudin" <peter.senna@collabora.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
stern@rowland.harvard.edu, thomas@winischhofer.net,
linux-usb@vger.kernel.org
Subject: Re: [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style: horizontal whitespace changes
Date: Fri, 15 Jan 2016 18:09:00 +0000 [thread overview]
Message-ID: <649b-56993580-3-19efa9e0@156463953> (raw)
In-Reply-To: <1452880572.8586.59.camel@perches.com>
CC: Alan Stern <stern@rowland.harvard.edu>
On Friday, January 15, 2016 18:56 CET, Joe Perches <joe@perches.com> wrote:
> On Fri, 2016-01-15 at 18:41 +0100, Peter Senna Tschudin wrote:
> > This patch fixes whitespace coding style issues that can be fixed
> > within a single line.
>
> trivia:
>
> > diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
> []
> > @@ -549,7 +549,7 @@ static int sisusb_recv_bulk_msg(struct sisusb_usb_data *sisusb, int ep, int len,
> > }
> >
> > static int sisusb_send_packet(struct sisusb_usb_data *sisusb, int len,
> > - struct sisusb_packet *packet)
> > + struct sisusb_packet *packet)
>
> I think all of these should use indentation alignment
> to open parenthesis.
That was my original idea too, but I have the impression things are different for usb, at least for usb-host. Alan, can you comment on this continuation line style issue here?
next prev parent reply other threads:[~2016-01-15 18:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 17:41 [PATCH V2 0/7] usb-misc: sisusbvga: cleanup and bug fix Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style: horizontal whitespace changes Peter Senna Tschudin
2016-01-15 17:56 ` Joe Perches
2016-01-15 18:09 ` Peter Senna [this message]
2016-01-15 18:21 ` Alan Stern
2016-01-15 17:41 ` [PATCH V2 2/7] usb-misc: sisusbvga: Fix coding style: vertical " Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 3/7] usb-misc: sisusbvga: Fix coding style: braces, parenthesis, comment Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 4/7] usb-misc: sisusbvga: Fix coding style: remove assignment from if tests Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 5/7] usb-misc: sisusbvga: Remove null test before calls to kfree() Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 6/7] usb-misc: sisusbvga: Remove memory allocation logs Peter Senna Tschudin
2016-01-15 17:41 ` [PATCH V2 7/7] usb-misc: sisusbvga: fix error path Peter Senna Tschudin
2016-01-15 17:51 ` [PATCH V2 0/7] usb-misc: sisusbvga: cleanup and bug fix Joe Perches
2016-01-15 18:07 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=649b-56993580-3-19efa9e0@156463953 \
--to=peter.senna@collabora.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@collabora.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®