Re: [PATCH 1/4] arm64: dts: qcom: sm8750: Add IPCC, SMP2P, AOSS and ADSP

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 01/11/2024 19:14, Melody Olvera wrote:
> 
> 
> On 11/1/2024 10:19 AM, Krzysztof Kozlowski wrote:
>> Add nodes for IPCC mailbox, SMP2P for ADSP, AOSS and the ADSP remoteproc
>> PAS loader (compatible with SM8550).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8750.dtsi | 140 +++++++++++++++++++++++++++++++++++
>>   1 file changed, 140 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> index 98ab82caa007ee63c395a3ce0f517e2bbeb0aecb..eb826b154dcb2d8165426ba2225548efd7547da8 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> [...]
>>   
>> @@ -538,6 +566,17 @@ gcc: clock-controller@100000 {
>>   			#power-domain-cells = <1>;
>>   		};
>>   
>> +		ipcc: mailbox@406000 {
>> +			compatible = "qcom,sm8750-ipcc", "qcom,ipcc";
>> +			reg = <0 0x00406000 0 0x1000>;
> 
> nit: unsure, but should thse be 0x0?

No, all recent upstream DTSI files nodes use simplified 0, because it is
shorter. Maybe except few cases, but then these could be corrected instead.

Best regards,
Krzysztof