From: Maxim Levitsky <mlevitsk@redhat.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH v2 0/5] Fix split view search and debug info navigation
Date: Mon, 29 Jun 2020 15:23:49 +0300 [thread overview]
Message-ID: <649f4c040c2f6dd2d83e984a88343917d498b4ad.camel@redhat.com> (raw)
In-Reply-To: <cover.1593423060.git.mchehab+huawei@kernel.org>
On Mon, 2020-06-29 at 11:35 +0200, Mauro Carvalho Chehab wrote:
> This series fixes some issues with search while on split view and fix the
> broken hyperlink navigation.
>
> The first patches restore the pre-Qt5 conversion behavior. The last
> one implements navigation on a different way. I opted to keep this one
> in separate, as this one is a new feature.
>
> Mauro Carvalho Chehab (5):
> kconfig: qconf: cleanup includes
> kconfig: qconf: ensure that only one item will be highlighted
> kconfig: qconf: make search fully work again on split mode
> kconfig: qconf: make debug links work again
> kconfig: qconf: navigate menus on hyperlinks
>
> scripts/kconfig/qconf.cc | 120 +++++++++++++++++++++++++++++----------
> scripts/kconfig/qconf.h | 15 ++---
> 2 files changed, 98 insertions(+), 37 deletions(-)
>
I tested the series, and it works really well here.
Thanks a lot for the patch 5, I indeed noted that
I am not sure it ever worked like that but it does now,
and it is a very good improvement in terms of usability.
There is still a tiny issue in patch 5 - sometimes already
selected items remain selected like it was in the search (now fixed).
Also I found another bug - clicking on '..' menu doesn't work:
For example select 'input device support', then 'keyboards' on the right,
then you can't get back. It also might be something that never worked,
and it doesn't bother me, I just note this for reference.
Thanks a lot for these fixes!
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2020-06-29 20:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 9:35 Mauro Carvalho Chehab
2020-06-29 9:35 ` [PATCH v2 1/5] kconfig: qconf: cleanup includes Mauro Carvalho Chehab
2020-06-29 9:35 ` [PATCH v2 2/5] kconfig: qconf: ensure that only one item will be highlighted Mauro Carvalho Chehab
2020-06-29 9:35 ` [PATCH v2 3/5] kconfig: qconf: make search fully work again on split mode Mauro Carvalho Chehab
2020-06-29 9:35 ` [PATCH v2 4/5] kconfig: qconf: make debug links work again Mauro Carvalho Chehab
2020-06-30 3:48 ` Masahiro Yamada
2020-06-29 9:35 ` [PATCH v2 5/5] kconfig: qconf: navigate menus on hyperlinks Mauro Carvalho Chehab
2020-06-30 2:49 ` Masahiro Yamada
2020-06-30 3:36 ` Masahiro Yamada
2020-06-30 6:25 ` Mauro Carvalho Chehab
2020-06-29 10:57 ` [PATCH] kconfig: qconf: re-implement setSelected() Mauro Carvalho Chehab
2020-06-29 12:23 ` Maxim Levitsky [this message]
2020-06-29 14:46 ` [PATCH v2 0/5] Fix split view search and debug info navigation Mauro Carvalho Chehab
2020-06-29 14:58 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=649f4c040c2f6dd2d83e984a88343917d498b4ad.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®