mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Xu <xuwei5@hisilicon.com>
To: Arnd Bergmann <arnd@kernel.org>, Huisong Li <lihuisong@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: kunpeng_hccs: fix size_t format string
Date: Mon, 14 Aug 2023 08:56:06 +0800	[thread overview]
Message-ID: <64D97BA6.3030609@hisilicon.com> (raw)
In-Reply-To: <20230812172116.3477379-1-arnd@kernel.org>

Hi Arnd,

On 2023/8/13 1:21, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Printing a size_t using the %lu format string causes a warning on
> architectures that define the type as 'unsigned int':
> 
> In file included from include/linux/device.h:15,
>                  from include/linux/acpi.h:14,
>                  from drivers/soc/hisilicon/kunpeng_hccs.c:25:
> drivers/soc/hisilicon/kunpeng_hccs.c: In function 'hccs_get_bd_info':
> drivers/soc/hisilicon/kunpeng_hccs.c:441:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> 
> Use the correct %zu format instead.
> 
> Fixes: 886bdf9c883bc ("soc: hisilicon: Support HCCS driver on Kunpeng SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I've already applied this one on top of the soc/drivers branch after I
> merged the branch with the new driver and noticed the regression.
> 
>  drivers/soc/hisilicon/kunpeng_hccs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c
> index 6864d203c6782..0d6f6bacd3f62 100644
> --- a/drivers/soc/hisilicon/kunpeng_hccs.c
> +++ b/drivers/soc/hisilicon/kunpeng_hccs.c
> @@ -438,7 +438,7 @@ static int hccs_get_bd_info(struct hccs_dev *hdev, u8 opcode,
>  	head = &rsp->rsp_head;
>  	if (head->data_len > buf_len) {
>  		dev_err(hdev->dev,
> -			"buffer overflow (buf_len = %lu, data_len = %u)!\n",
> +			"buffer overflow (buf_len = %zu, data_len = %u)!\n",
>  			buf_len, head->data_len);
>  		return -ENOMEM;
>  	}
> 

Thanks!

Best Regards,
Wei

  reply	other threads:[~2023-08-14  1:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-12 17:21 Arnd Bergmann
2023-08-14  0:56 ` Wei Xu [this message]
2023-08-14  3:52   ` lihuisong (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64D97BA6.3030609@hisilicon.com \
    --to=xuwei5@hisilicon.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=lihuisong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®