From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 06/15] memory: tegra: Setup interrupts mask before requesting IRQ
Date: Tue, 20 Feb 2018 19:25:19 +0300 [thread overview]
Message-ID: <64a44d4c9083b14caba3fe215891519ff652c195.1519141896.git.digetx@gmail.com> (raw)
In-Reply-To: <cover.1519141896.git.digetx@gmail.com>
In-Reply-To: <cover.1519141896.git.digetx@gmail.com>
This avoids unwanted interrupt during MC driver probe.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/memory/tegra/mc.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index d2005b995821..e55b9733bd83 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -407,14 +407,6 @@ static int tegra_mc_probe(struct platform_device *pdev)
return mc->irq;
}
- err = devm_request_irq(&pdev->dev, mc->irq, tegra_mc_irq, IRQF_SHARED,
- dev_name(&pdev->dev), mc);
- if (err < 0) {
- dev_err(&pdev->dev, "failed to request IRQ#%u: %d\n", mc->irq,
- err);
- return err;
- }
-
WARN(!mc->soc->client_id_mask, "Missing client ID mask for this SoC\n");
value = MC_INT_DECERR_MTS | MC_INT_SECERR_SEC | MC_INT_DECERR_VPR |
@@ -423,6 +415,14 @@ static int tegra_mc_probe(struct platform_device *pdev)
mc_writel(mc, value, MC_INTMASK);
+ err = devm_request_irq(&pdev->dev, mc->irq, tegra_mc_irq, IRQF_SHARED,
+ dev_name(&pdev->dev), mc);
+ if (err < 0) {
+ dev_err(&pdev->dev, "failed to request IRQ#%u: %d\n", mc->irq,
+ err);
+ return err;
+ }
+
return 0;
}
--
2.16.1
next prev parent reply other threads:[~2018-02-20 16:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 16:25 [PATCH v3 00/15] Memory controller hot reset Dmitry Osipenko
2018-02-20 16:25 ` [PATCH v3 01/15] dt-bindings: arm: tegra: Remove duplicated Tegra30+ MC binding Dmitry Osipenko
2018-03-01 21:53 ` Rob Herring
2018-02-20 16:25 ` [PATCH v3 02/15] dt-bindings: memory: tegra: Document #reset-cells property of the Tegra30 MC Dmitry Osipenko
2018-03-01 21:54 ` Rob Herring
2018-02-20 16:25 ` [PATCH v3 03/15] dt-bindings: arm: tegra: Document #reset-cells property of the Tegra20 MC Dmitry Osipenko
2018-03-01 21:55 ` Rob Herring
2018-02-20 16:25 ` [PATCH v3 04/15] dt-bindings: memory: tegra: Add hot resets definitions Dmitry Osipenko
2018-03-01 21:56 ` Rob Herring
2018-02-20 16:25 ` [PATCH v3 05/15] memory: tegra: Do not handle spurious interrupts Dmitry Osipenko
2018-02-20 16:25 ` Dmitry Osipenko [this message]
2018-02-20 16:25 ` [PATCH v3 07/15] memory: tegra: Apply interrupts mask per SoC Dmitry Osipenko
2018-02-20 16:25 ` [PATCH v3 08/15] memory: tegra: Remove unused headers inclusions Dmitry Osipenko
2018-02-20 16:25 ` [PATCH v3 09/15] memory: tegra: Squash tegra20-mc into common tegra-mc driver Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 10/15] memory: tegra: Introduce memory client hot reset Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 11/15] memory: tegra: Add Tegra210 memory controller hot resets Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 12/15] memory: tegra: Add Tegra124 " Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 13/15] memory: tegra: Add Tegra114 " Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 14/15] memory: tegra: Add Tegra30 " Dmitry Osipenko
2018-02-20 16:36 ` [PATCH v3 15/15] memory: tegra: Add Tegra20 " Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64a44d4c9083b14caba3fe215891519ff652c195.1519141896.git.digetx@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®