From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Mehmet Fide" <mehmet.fide@gmail.com>,
"Ping-Ke Shih" <pkshih@realtek.com>
Cc: "Bitterblue Smith" <rtl8821cerfe2@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
mehmet.fide@screeningeagle.com, luka.gejak@linux.dev
Subject: Re: [PATCH rtw-next v3 1/2] wifi: rtw88: download the beacon the reserved page was built with
Date: Mon, 05 Oct 2026 17:36:20 +0000 [thread overview]
Message-ID: <64b006322730e0a078983458932dae35255e65dc@linux.dev> (raw)
In-Reply-To: <20261005143523.130287-2-mehmet.fide@gmail.com>
October 5, 2026 at 16:35, "Mehmet Fide" <mehmet.fide@gmail.com mailto:mehmet.fide@gmail.com?to=%22Mehmet%20Fide%22%20%3Cmehmet.fide%40gmail.com%3E > wrote:
>
> From: Mehmet Fide <mehmet.fide@screeningeagle.com>
>
> rtw_fw_download_rsvd_page() downloads the beacon twice: once as part of
> the reserved page and once more on its own, so that the firmware ends up
> with a TX descriptor that describes the beacon rather than the whole
> page. The second download fetched a new beacon from mac80211 instead of
> downloading the one the page already holds.
>
> Besides the extra work, every beacon fetch advances the DTIM count and,
> while a channel switch is announced, the CSA countdown; doing it twice
> per update lets a countdown that starts at 2 reach 0, which mac80211
> warns about. Hand the beacon skb out of the page build and download
> that. The hw scan, which downloads the beacon without a page build,
> keeps fetching its own.
>
> Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
Patch 1 looks good to me.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-10-05 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 14:35 [PATCH rtw-next v3 0/2] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-10-05 14:35 ` [PATCH rtw-next v3 1/2] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-10-05 17:36 ` Luka Gejak [this message]
2026-10-06 7:46 ` Mehmet Fide
2026-10-05 14:35 ` [PATCH rtw-next v3 2/2] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-10-05 17:33 ` [PATCH " Luka Gejak
2026-10-06 7:46 ` [PATCH rtw-next " Mehmet Fide
2026-10-06 1:26 ` Ping-Ke Shih
2026-10-06 7:46 ` Mehmet Fide
2026-10-06 7:54 ` Ping-Ke Shih
2026-10-06 8:16 ` Mehmet Fide
-- strict thread matches above, loose matches on Subject: below --
2026-10-05 14:33 [PATCH rtw-next v3 0/2] wifi: rtw88: " Mehmet Fide
2026-10-05 14:33 ` [PATCH rtw-next v3 1/2] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64b006322730e0a078983458932dae35255e65dc@linux.dev \
--to=luka.gejak@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mehmet.fide@gmail.com \
--cc=mehmet.fide@screeningeagle.com \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®