From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755932AbdKCOYt (ORCPT ); Fri, 3 Nov 2017 10:24:49 -0400 Received: from osg.samsung.com ([64.30.133.232]:57371 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdKCOYq (ORCPT ); Fri, 3 Nov 2017 10:24:46 -0400 Subject: Re: [PATCH] selftests: ftrace: add more config fragments To: Steven Rostedt , lyang0 Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Shuah Khan , Shuah Khan References: <1508581070-19052-1-git-send-email-lei.yang@windriver.com> <678518a0-48fd-3d03-bad0-e0d65eefd16d@osg.samsung.com> <4f08939a-d651-0d9c-6968-2a32f94677ba@windriver.com> <20171103091318.72d1018b@vmware.local.home> From: Shuah Khan Message-ID: <64b210b8-43cc-d758-08cb-680beddfb69a@osg.samsung.com> Date: Fri, 3 Nov 2017 08:24:36 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171103091318.72d1018b@vmware.local.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2017 07:13 AM, Steven Rostedt wrote: > On Fri, 3 Nov 2017 15:23:56 +0800 > lyang0 wrote: > > >>>> diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config >>>> index 8a1c9f9..b01924c 100644 >>>> --- a/tools/testing/selftests/ftrace/config >>>> +++ b/tools/testing/selftests/ftrace/config >>>> @@ -1,2 +1,6 @@ >>>> CONFIG_KPROBES=y >>>> CONFIG_FTRACE=y >>>> +CONFIG_FUNCTION_PROFILER=y >>>> +CONFIG_TRACER_SNAPSHOT=y >>>> +CONFIG_STACK_TRACER=y >>>> +CONFIG_HIST_TRIGGERS=y >>>> >>> Hi Steve/Masami, >>> >>> Are you good with this change. Please give me an Ack. >> >> Hi, >> >> any comments ? > > You should have Cc'd me in the first email. Thanks to Shuah for > pointing it out to us. > > Anyway, I'm fine with it. > > Acked-by: Steven Rostedt (VMware) > Thanks Steve. I will get this into linux-kselftest 4.15-rc1 Lei, Please do the following when you send your future patches: Not stating the obvious, make sure to test and include what does this patch fix in your commit log. 1. Run scripts/checkpatch.pl 2. Run scripts/get_maintainer.pl 3. Please give us at least a week before pinging us. We have all been traveling all of last week and going through out Inboxes. Please refer to Documentation/process/submitting-patches.rst for details on how to send patches. btw for this patch if you ran scripts/get_maintainer.pl, you would have seen the correct list to send the patch to in the first place, which would have made it easier. Steven Rostedt (maintainer:TRACING) Ingo Molnar (maintainer:TRACING) Shuah Khan (maintainer:KERNEL SELFTEST FRAMEWORK) linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK) linux-kernel@vger.kernel.org (open list) thanks, -- Shuah