From: Hans Verkuil <hverkuil@xs4all.nl>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
mchehab@kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, hans.verkuil@cisco.com,
hugues.fruchet@st.com
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH] media: stm32: dcmi: replace "%p" with "%pK"
Date: Fri, 6 Jul 2018 15:51:07 +0200 [thread overview]
Message-ID: <64b2a2ea-2da9-c40d-eae4-6375079771e7@xs4all.nl> (raw)
In-Reply-To: <20180706130355.22100-1-benjamin.gaignard@st.com>
On 06/07/18 15:03, Benjamin Gaignard wrote:
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.
This patch no longer applies. AFAICT it is obsolete after some code reorg.
Regards,
Hans
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index 2e1933d872ee..fe90672cf16f 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -1753,7 +1753,7 @@ static int dcmi_probe(struct platform_device *pdev)
>
> ret = clk_prepare(mclk);
> if (ret) {
> - dev_err(&pdev->dev, "Unable to prepare mclk %p\n", mclk);
> + dev_err(&pdev->dev, "Unable to prepare mclk %pK\n", mclk);
> goto err_dma_release;
> }
>
>
prev parent reply other threads:[~2018-07-06 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 13:03 Benjamin Gaignard
2018-07-06 13:51 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64b2a2ea-2da9-c40d-eae4-6375079771e7@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=hans.verkuil@cisco.com \
--cc=hugues.fruchet@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®