From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D10C63684 for ; Wed, 26 Jan 2022 02:32:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236440AbiAZCcv (ORCPT ); Tue, 25 Jan 2022 21:32:51 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:16739 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236468AbiAZCcu (ORCPT ); Tue, 25 Jan 2022 21:32:50 -0500 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Jk72F6gZszZfSK; Wed, 26 Jan 2022 10:28:53 +0800 (CST) Received: from [10.67.110.173] (10.67.110.173) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 26 Jan 2022 10:32:47 +0800 Message-ID: <64bb3746-07b4-aad4-7ee0-dccda6c7d4e1@huawei.com> Date: Wed, 26 Jan 2022 10:32:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RESEND][PATCH] Documentation: added order requirement for ima_hash= Content-Language: en-US To: Jonathan Corbet , CC: , , , , , References: <20220125090237.120357-1-guozihua@huawei.com> <87o83zwdxm.fsf@meer.lwn.net> From: "Guozihua (Scott)" In-Reply-To: <87o83zwdxm.fsf@meer.lwn.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.173] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500024.china.huawei.com (7.185.36.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/1/26 8:14, Jonathan Corbet wrote: > GUO Zihua writes: > >> From: Guo Zihua >> >> Commandline parameter ima_hash= and ima_template= has order requirement >> for them to work correctly together. Namely ima_hash= must be >> specified after ima_template=, otherwise ima_template= will be ignored. >> >> The reason is that when handling ima_hash=, ima template would be set to >> the default value if it has not been initialized already, and that value >> cannot be changed afterwards by ima_template=. >> >> This patch adds this limitation to the documentation. >> >> Reviewed-by: Roberto Sassu >> Signed-off-by: Guo Zihua > > I've applied this, but I'm wondering: where did this review take place? > I can't find it on the lists... > > Thanks, > > jon > . Hi Jonathan, Thank you very much and sorry for the confusion here. The reviewed by is more like a face-to-face peer review and I would like to mention that in the patch. If this is problematic I would stop doing that from now on. -- Best GUO Zihua