From: "Torsten Kaiser" <just.for.lkml@googlemail.com>
To: "Tejun Heo" <htejun@gmail.com>
Cc: "Jens Axboe" <jens.axboe@oracle.com>,
"Jeff Garzik" <jeff@garzik.org>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: sata_sil24 broken since 2.6.23-rc4-mm1
Date: Thu, 11 Oct 2007 19:51:11 +0200 [thread overview]
Message-ID: <64bb37e0710111051w40409d61w91a4ec155abab41a@mail.gmail.com> (raw)
In-Reply-To: <470DC213.5080307@gmail.com>
On 10/11/07, Tejun Heo <htejun@gmail.com> wrote:
> Torsten Kaiser wrote:
> >>> That missing +1 would explain, why the SGE_TRM never gets set.
> >> Thanks a lot for tracking this down. Does changing the above code fix
> >> your problem?
> >
> > I did not try it.
> > I'm not an libata expert and while this change looks suspicios, I
> > can't be 100% sure if that change was intended.
> > And I did not want to experiment this deep in the code and risk
> > corrupting the hole drive.
>
> I don't think you would risk too much by changing that bit of code.
> Please try it.
The debug output now shows that SGE_TRM is getting set.
I will try to reproduce the error tomorrow morning, and report if I'm
still seeing it.
Reporting that I'm no longer see it is sadly not a good indicator, as
it also seems to depend on other factors like memory layout and/or
code alignment.
Torsten
next prev parent reply other threads:[~2007-10-11 17:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 20:26 Torsten Kaiser
2007-09-27 4:54 ` Tejun Heo
2007-09-27 4:57 ` Tejun Heo
2007-09-27 6:14 ` Torsten Kaiser
2007-09-27 6:24 ` Jeff Garzik
2007-09-27 17:34 ` Torsten Kaiser
2007-09-27 20:22 ` Tejun Heo
2007-09-28 5:36 ` Torsten Kaiser
2007-09-30 6:00 ` Torsten Kaiser
2007-09-30 14:34 ` Tejun Heo
2007-09-30 16:19 ` Torsten Kaiser
2007-09-30 17:39 ` Tejun Heo
2007-09-30 18:39 ` Torsten Kaiser
2007-10-01 18:00 ` Torsten Kaiser
2007-10-03 15:21 ` Torsten Kaiser
2007-10-03 15:55 ` Torsten Kaiser
2007-10-03 16:38 ` Matt Mackall
2007-10-03 17:36 ` Torsten Kaiser
2007-10-03 17:51 ` Matt Mackall
2007-10-03 18:06 ` Torsten Kaiser
2007-10-04 5:32 ` Torsten Kaiser
2007-10-04 17:05 ` Matt Mackall
2007-10-05 6:06 ` Torsten Kaiser
2007-10-07 8:44 ` Torsten Kaiser
2007-10-07 14:39 ` Torsten Kaiser
2007-10-11 3:25 ` Tejun Heo
2007-10-11 5:54 ` Torsten Kaiser
2007-10-11 6:26 ` Tejun Heo
2007-10-11 17:51 ` Torsten Kaiser [this message]
2007-10-11 8:26 ` Jens Axboe
2007-10-11 8:36 ` Tejun Heo
2007-10-11 10:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64bb37e0710111051w40409d61w91a4ec155abab41a@mail.gmail.com \
--to=just.for.lkml@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome