From: Md Sadre Alam <quic_mdalam@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>, <vkoul@kernel.org>,
<martin.petersen@oracle.com>, <kees@kernel.org>,
<av2082000@gmail.com>, <fenghua.yu@intel.com>,
<linux-arm-msm@vger.kernel.org>, <dmaengine@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <quic_varada@quicinc.com>, <quic_srichara@quicinc.com>
Subject: Re: [PATCH v2] dmaengine: qcom: bam_dma: Avoid writing unavailable register
Date: Mon, 9 Dec 2024 10:59:28 +0530 [thread overview]
Message-ID: <64be3126-5d07-7490-28fc-20afd2635b8c@quicinc.com> (raw)
In-Reply-To: <2afca6ca-10eb-43b3-8730-386d6ca84b60@linaro.org>
On 12/5/2024 5:58 PM, Bryan O'Donoghue wrote:
> On 05/12/2024 12:00, Md Sadre Alam wrote:
>
> The commit log:
>
>> Avoid writing unavailable register in BAM-Lite mode.
>> BAM_DESC_CNT_TRSHLD register is unavailable in BAM-Lite
>> mode. Its only available in BAM-NDP mode. So avoid writing
>
> and the action taken in the code:
>
>> + if (bdev->bam_revision >= BAM_LITE && bdev->bam_revision < BAM_NDP)
>> + writel_relaxed(DEFAULT_CNT_THRSHLD,
>
> Really don't match up. You've said in your commit log
> BAM_DESC_CNT_TRSHLD is unavailable to the LITE module but, then you say
> if (bam_revision >= BAM_LITE...)
>
> How can checking if the revision == BAM_LITE match up with the stated
> objective in your commit log => _not_ writing to DEFAULT_CNT_THRSHLD in
> lite mode ... ?
Thank you for pointing that out. I'll address this in the next revision.
>
> ---
> bod
prev parent reply other threads:[~2024-12-09 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 12:00 Md Sadre Alam
2024-12-05 12:28 ` Bryan O'Donoghue
2024-12-09 5:29 ` Md Sadre Alam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64be3126-5d07-7490-28fc-20afd2635b8c@quicinc.com \
--to=quic_mdalam@quicinc.com \
--cc=av2082000@gmail.com \
--cc=bryan.odonoghue@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=kees@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®