From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CC9D1AA79F for ; Fri, 4 Oct 2024 16:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728058174; cv=none; b=VSknv+TCe0hgOvOHVo86UTG2XWcrgSKlNkvin2yZUqwPnxblBXBF1r2wpc8rkvNdwcQHSGPu5gC/ROoD3G/Gnoai8Sd1suqfszapwG0cPine+wPDb1FH9KDXeQJ1gnbkshEUiiwA4l3OZQ5D1k4Yckwq0mCLyREesQGlZ0QKo3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728058174; c=relaxed/simple; bh=eoaWatCnhBU62iXtHmx39mSv9OQWXaKw4pJX9ho+iJE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G+QUVUQFQuUWM7QQqMvD/x2o74LJQMlyb6+d5ayyB06ZJ16ZACxAmSGDv8BE+OIcR4iS51MzTax62M4psnpHMec3VGWbZ469O9ByGyy6qLW9E25PqJzrh5tO2w+IXPTujqJwRfYCm5yna+M7GgZ9bdqRjxAmWFukmQtFFtUvUek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=bn9NoN7w; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="bn9NoN7w" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7ae3fcec5feso217932385a.0 for ; Fri, 04 Oct 2024 09:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1728058171; x=1728662971; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=5h8wpPh30s6KF37peScNelcNl3ZFS3xlRdD1aJCpMMs=; b=bn9NoN7wvaqsVKOpRoKBYsxzISiRpBSmr1TXhlV+uNOhsZmeffXquUUomILkUmWQ9t 0/M19NiUAvJcICOcxxVewDrxDPXYptUzNRN6xBpE3l7BaRk1VWpAQvG4qbG3rK/1sOOj xSp5F/wNWnwM7Xq/9+2Xdvnqwvrag0dBJzisI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728058171; x=1728662971; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5h8wpPh30s6KF37peScNelcNl3ZFS3xlRdD1aJCpMMs=; b=j0bIX2xr3CQXuYw9TN1jQl/HVX3iyP1kGOTrsOx0TK7IjQPoHQAVi14aRHLyOh9N18 V0ZwI5uWsJNXRiJVBfmOifEiD2mkPj+6Xe4nL1YTmfgnYY/78POYSMtrp6KRwtlbVbx0 tIU2ukl3LyUG94WsbuJ7kqsLqZf2jtPpNGId8A/diPoiKld8VgXkxt4OZuXV6glOYx7Z uO6vKwJBlumV+VN88v+xPqjPSG1trCUF1/D+gfiBeM+MYl88c1D2AR8jHC5+45yjgnwt T8P2IpqEI7uGvMqzeDHhCANc7zuhZUk0yAqLbjgbvOfqKl7oP7qb+bYL+NymM48/D5qR Grsg== X-Forwarded-Encrypted: i=1; AJvYcCU9lDmZ25OiR09t0dcsjgeVhCTaSptfoJIoNyEu1zM7hcL9bLeT+Cxl0nASQUBc1VmWQ9kfCkGK4PQHExk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzfc7gIg50/ClGxzVsGETavRO6H/JWVHOLbFppz/8dkKHukRjCk P3+YR/hEMtCC7wrw4cf4n/McOxrEj7+48we9fkLLQlocvEazurn1DWc0K/sEuw== X-Google-Smtp-Source: AGHT+IGtCk7ebsbdtPTQyF7KwUl+f/hTvdermQbklRaY7Diuv4J09nixlWJsdMN8MEXs3rPHxFGdUQ== X-Received: by 2002:a05:620a:4108:b0:7a9:beaf:ce61 with SMTP id af79cd13be357-7ae6f486860mr569681385a.45.1728058170895; Fri, 04 Oct 2024 09:09:30 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae6b29f0dbsm150110485a.24.2024.10.04.09.09.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Oct 2024 09:09:29 -0700 (PDT) Message-ID: <64c13754-79b2-4480-9f97-7987fe097d8c@broadcom.com> Date: Fri, 4 Oct 2024 09:09:25 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: dsa: bcm_sf2: fix crossbar port bitwidth logic To: Sam Edwards , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Andrew Lunn , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241003212301.1339647-1-CFSworks@gmail.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20241003212301.1339647-1-CFSworks@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/3/24 14:23, Sam Edwards wrote: > The SF2 crossbar register is a packed bitfield, giving the index of the > external port selected for each of the internal ports. On BCM4908 (the > only currently-supported switch family with a crossbar), there are 2 > internal ports and 3 external ports, so there are 2 bits per internal > port. > > The driver currently conflates the "bits per port" and "number of ports" > concepts, lumping both into the `num_crossbar_int_ports` field. Since it > is currently only possible for either of these counts to have a value of > 2, there is no behavioral error resulting from this situation for now. > > Make the code more readable (and support the future possibility of > larger crossbars) by adding a `num_crossbar_ext_bits` field to represent > the "bits per port" count and relying on this where appropriate instead. > > Signed-off-by: Sam Edwards Reviewed-by: Florian Fainelli -- Florian