From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6B0C43217 for ; Tue, 8 Nov 2022 09:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233829AbiKHJlN (ORCPT ); Tue, 8 Nov 2022 04:41:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233761AbiKHJlA (ORCPT ); Tue, 8 Nov 2022 04:41:00 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3AED53134B; Tue, 8 Nov 2022 01:40:59 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 217251FB; Tue, 8 Nov 2022 01:41:05 -0800 (PST) Received: from [10.57.67.115] (unknown [10.57.67.115]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A8493F534; Tue, 8 Nov 2022 01:40:56 -0800 (PST) Message-ID: <64c239e6-2df9-fd98-ee1e-151218d0d070@arm.com> Date: Tue, 8 Nov 2022 09:40:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v14 0/9] Coresight: Add support for TPDM and TPDA From: Suzuki K Poulose To: Jinlong Mao , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach Cc: Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, Bjorn Andersson References: <20221102091915.15281-1-quic_jinlmao@quicinc.com> <69a3cd4b-c4b0-b998-b4c1-70a928690972@arm.com> <102a8c21-2b78-56ca-874a-194e878dff8f@quicinc.com> <9072665a-f019-975b-7b3b-d3f37ea71425@arm.com> In-Reply-To: <9072665a-f019-975b-7b3b-d3f37ea71425@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/2022 09:37, Suzuki K Poulose wrote: > On 08/11/2022 05:54, Jinlong Mao wrote: >> >> On 11/8/2022 2:38 AM, Suzuki K Poulose wrote: >>> On 02/11/2022 09:19, Mao Jinlong wrote: >>>> This series adds support for the trace performance monitoring and >>>> diagnostics hardware (TPDM and TPDA). It is composed of two major >>>> elements. >>>> a) Changes for original coresight framework to support for TPDM and >>>> TPDA. >>>> b) Add driver code for TPDM and TPDA. >>>> >>>> Introduction of changes for original coresight framework >>>> Support TPDM as new coresight source. >>>> Since only STM and ETM are supported as coresight source originally. >>>> TPDM is a newly added coresight source. We need to change >>>> the original way of saving coresight path to support more types source >>>> for coresight driver. >>>> The following patch is to add support more coresight sources. >>>>      coresight: core: Use IDR for non-cpu bound sources' paths. >>>> >>> ---8>--- >>> >>>> Introduction of TPDM and TPDA >>>> TPDM - The trace performance monitoring and diagnostics monitor or >>>> TPDM in >>>> short serves as data collection component for various dataset types >>>> specified in the QPMDA(Qualcomm performance monitoring and diagnostics >>>> architecture) spec. The primary use case of the TPDM is to collect data >>>> from different data sources and send it to a TPDA for packetization, >>>> timestamping and funneling. >>>>       Coresight: Add coresight TPDM source driver >>>>       dt-bindings: arm: Adds CoreSight TPDM hardware definitions >>>>       coresight-tpdm: Add DSB dataset support >>>>       coresight-tpdm: Add integration test support >>>>       docs: sysfs: coresight: Add sysfs ABI documentation for TPDM >>>> >>>> TPDA - The trace performance monitoring and diagnostics aggregator or >>>> TPDA in short serves as an arbitration and packetization engine for the >>>> performance monitoring and diagnostics network as specified in the >>>> QPMDA >>>> (Qualcomm performance monitoring and diagnostics architecture) >>>> specification. The primary use case of the TPDA is to provide >>>> packetization, funneling and timestamping of Monitor data as specified >>>> in the QPMDA specification. >>>> The following patch is to add driver for TPDA. >>>>       Coresight: Add TPDA link driver >>>>       dt-bindings: arm: Adds CoreSight TPDA hardware definitions >>>> >>>> The last patch of this series is a device tree modification, which add >>>> the TPDM and TPDA configuration to device tree for validating. >>>>      ARM: dts: msm: Add coresight components for SM8250 >>>>      ARM: dts: msm: Add tpdm mm/prng for sm8250 >>>> >>>> Once this series patches are applied properly, the tpdm and tpda nodes >>>> should be observed at the coresight path /sys/bus/coresight/devices >>>> e.g. >>>> /sys/bus/coresight/devices # ls -l | grep tpd >>>> tpda0 -> ../../../devices/platform/soc@0/6004000.tpda/tpda0 >>>> tpdm0 -> ../../../devices/platform/soc@0/6c08000.mm.tpdm/tpdm0 >>>> >>>> We can use the commands are similar to the below to validate TPDMs. >>>> Enable coresight sink first. >>>> >>>> echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink >>>> echo 1 > /sys/bus/coresight/devices/tpdm0/enable_source >>>> echo 1 > /sys/bus/coresight/devices/tpdm0/integration_test >>>> echo 2 > /sys/bus/coresight/devices/tpdm0/integration_test >>>> The test data will be collected in the coresight sink which is enabled. >>>> If rwp register of the sink is keeping updating when do >>>> integration_test (by cat tmc_etf0/mgmt/rwp), it means there is data >>>> generated from TPDM to sink. >>>> >>>> There must be a tpda between tpdm and the sink. When there are some >>>> other trace event hw components in the same HW block with tpdm, tpdm >>>> and these hw components will connect to the coresight funnel. When >>>> there is only tpdm trace hw in the HW block, tpdm will connect to >>>> tpda directly. >>>>         +---------------+                +-------------+ >>>>      |  tpdm@6c08000 |                |tpdm@684C000 | >>>>      +-------|-------+                +------|------+ >>>>              |                               | >>>>      +-------|-------+                       | >>>>      | funnel@6c0b000|                       | >>>>      +-------|-------+                       | >>>>              |                               | >>>>      +-------|-------+                       | >>>>      |funnel@6c2d000 |                       | >>>>      +-------|-------+                       | >>>>              |                               | >>>>              |    +---------------+          | >>>>              +----- tpda@6004000  -----------+ >>>>                   +-------|-------+ >>>>                           | >>>>                   +-------|-------+ >>>>                   |funnel@6005000 | >>>>                   +---------------+ >>>> >>> >>> --8<-- >>> >>> Please could you add the above to a Documentation file (Of course >>> skip the description of patches). >> Sure. I will add them to the Documentation file. >>> >>> >>>> This patch series depends on patch series: >>>> "[v5,00/14] coresight: Add new API to allocate trace source ID values" >>>> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20221101163103.17921-1-mike.leach@linaro.org/ >>> >>> So, is there a strict binding between a TPDM and a TPDA ? >>> i.e., Multiple TPDMs could never end up reaching the sam >>> TPDA ? I see that the TPDMs could be connected to funnels >>> and thus other TPDMs could be connected to the same funnels >>> and thus reach the same TPDA. >> There is no strict binding between TPDM and TPDA. >> TPDA can have multiple TPDMs connect to it. >> But There must be only one TPDA in the path from the TPDM source to >> TMC sink. >> TPDM can directly connect to TPDA's inport >> or connect to funnel which will connect to TPDA's inport. >>> >>> Also, the trace-id is bound to TPDA and not TPDM. So, if >>> we have multiple TPDMs, trace decoding is going to be >>> impossible. >> The TPDMs which are connected to same TPDA shares the same >> trace-id. When TPDA does packetization, different port will have >> unique channel number for decoding. So this assumes that nobody connects two TPDMs to a funnel, which then connects to a TPDA ? (i.e. tpdm@684C000 above must not be connected to funnel@6c0b000 or funnel@6c2d000). In which case, two of them end up in the same port of the TPDA. Suzuki