From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Sergiu Moga <sergiu.moga@microchip.com>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<alexandre.belloni@bootlin.com>, <claudiu.beznea@microchip.com>
Cc: <linux-crypto@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: atmel: Add capability case for the 0x600 SHA and AES IP versions
Date: Thu, 8 Dec 2022 11:56:47 +0100 [thread overview]
Message-ID: <64c9bdaf-a138-a9bb-17dd-63ad96d2292b@microchip.com> (raw)
In-Reply-To: <20221207135953.136557-1-sergiu.moga@microchip.com>
On 07/12/2022 at 14:59, Sergiu Moga wrote:
> In order for the driver to be made aware of the capabilities of the SHA
> and AES IP versions 0x600 , such as those present on the SAM9X60 SoC's,
> add a corresponding switch case to the capability method of the respective
> drivers. Without this, besides the capabilities not being correctly set,
> the self tests may hang since the driver is endlessly waiting for a
> completion to be set by a never occurring DMA interrupt handler.
>
> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks Sergiu, best regards,
Nicolas
> ---
> drivers/crypto/atmel-aes.c | 1 +
> drivers/crypto/atmel-sha.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
> index 886bf258544c..063394cfa874 100644
> --- a/drivers/crypto/atmel-aes.c
> +++ b/drivers/crypto/atmel-aes.c
> @@ -2510,6 +2510,7 @@ static void atmel_aes_get_cap(struct atmel_aes_dev *dd)
> /* keep only major version number */
> switch (dd->hw_version & 0xff0) {
> case 0x700:
> + case 0x600:
> case 0x500:
> dd->caps.has_dualbuff = 1;
> dd->caps.has_cfb64 = 1;
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index ca4b01926d1b..00be792e605c 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -2509,6 +2509,7 @@ static void atmel_sha_get_cap(struct atmel_sha_dev *dd)
> /* keep only major version number */
> switch (dd->hw_version & 0xff0) {
> case 0x700:
> + case 0x600:
> case 0x510:
> dd->caps.has_dma = 1;
> dd->caps.has_dualbuff = 1;
--
Nicolas Ferre
next prev parent reply other threads:[~2022-12-08 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 13:59 Sergiu Moga
2022-12-08 10:56 ` Nicolas Ferre [this message]
2022-12-30 15:03 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64c9bdaf-a138-a9bb-17dd-63ad96d2292b@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergiu.moga@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®