From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1A1C35240 for ; Sun, 2 Feb 2020 09:01:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D523320643 for ; Sun, 2 Feb 2020 09:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbgBBJB3 (ORCPT ); Sun, 2 Feb 2020 04:01:29 -0500 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:50596 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbgBBJB3 (ORCPT ); Sun, 2 Feb 2020 04:01:29 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R681e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Tox1Zpm_1580634085; Received: from JosephdeMacBook-Pro.local(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0Tox1Zpm_1580634085) by smtp.aliyun-inc.com(127.0.0.1); Sun, 02 Feb 2020 17:01:25 +0800 Subject: Re: [PATCH] ocfs2: remove trivial nowait check for buffered read/write To: qiwuchen55@gmail.com, mark@fasheh.com, jlbec@evilplan.org, trivial@kernel.org Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, chenqiwu References: <1580541178-7853-1-git-send-email-qiwuchen55@gmail.com> From: Joseph Qi Message-ID: <64ca27c4-c3ee-2a43-3d97-35ad55e11472@linux.alibaba.com> Date: Sun, 2 Feb 2020 17:01:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <1580541178-7853-1-git-send-email-qiwuchen55@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/2/1 15:12, qiwuchen55@gmail.com wrote: > From: chenqiwu > > Remove trivial nowait check for buffered read/write, since > buffered read is checked in generic_file_read_iter()-> > generic_file_buffered_read(), buffered write is checked in > generic_write_checks(). > You are right, but check it at the beginning of ocfs2_file_[read|write]_iter() will save much effort for lock ops, so I'd like to leave them there. Thanks, Joseph