From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F211C282E1 for ; Fri, 24 May 2019 22:20:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25AE921872 for ; Fri, 24 May 2019 22:20:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="bv+fvRCE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404327AbfEXWUq (ORCPT ); Fri, 24 May 2019 18:20:46 -0400 Received: from node.akkea.ca ([192.155.83.177]:58206 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404176AbfEXWUp (ORCPT ); Fri, 24 May 2019 18:20:45 -0400 Received: by node.akkea.ca (Postfix, from userid 33) id 734D24E204B; Fri, 24 May 2019 22:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1558736445; bh=p20jB4BQU4AvtbWwn3XeTjPaRii6ZgAKH7/dXJoEJig=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=bv+fvRCEnBF18NNZaLElZPetLVBlma51ewNgSeJNF1Qvp7gLdBtgiTJau8DCU5HMK tQ1T5dyWfnVgopujkczBCJZ4f2vyPlhBNzBh5raJh2ecZaxp81wzQVtcNnjWx4PCXv gJUumLG5Tk7k9rsX4g57s2Io3/u5jqyQvRd7EouY= To: Pavel Machek Subject: Re: [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 24 May 2019 15:20:45 -0700 From: Angus Ainslie Cc: angus.ainslie@puri.sm, Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <1e6c0664949f38452b8f14b901bff513@www.akkea.ca> References: <20190520142330.3556-1-angus@akkea.ca> <20190520142330.3556-3-angus@akkea.ca> <20190523191926.GB3803@xo-6d-61-c0.localdomain> <1e6c0664949f38452b8f14b901bff513@www.akkea.ca> Message-ID: <64cc01b6cc6590e328e7b488bedb9dc8@www.akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On 2019-05-24 15:00, Angus Ainslie wrote: > Hi Pavel, > > On 2019-05-23 12:19, Pavel Machek wrote: >> Hi! >> >>> - LEDs >>> - gyro >>> - magnetometer >> >>> + leds { >>> + compatible = "gpio-leds"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_gpio_leds>; >>> + >>> + led1 { >>> + label = "LED 1"; >> >> So, what kind of LED do you have, and what color is it? label should >> probably be something like >> notify:green. >> > > As we don't have a specific use for these yet does it really matter if > there is a colour or a number associated with them ? > >>> + charger@6b { /* bq25896 */ >>> + compatible = "ti,bq25890"; >>> + reg = <0x6b>; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_charger>; >>> + interrupt-parent = <&gpio3>; >>> + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; >>> + ti,battery-regulation-voltage = <4192000>; /* 4.192V */ >>> + ti,charge-current = <1600000>; /* 1.6 A */ >> >> No space before A, for consistency. >> >>> + ti,termination-current = <66000>; /* 66mA */ >>> + ti,precharge-current = <1300000>; /* 1.3A */ >> >> I thought precharge is usually something low, because you are not yet >> sure of battery health...? >> > > I think I put that in incorrectly. The intention was 130mA. > >>> + ti,minimum-sys-voltage = <2750000>; /* 2.75V */ >> >> Are you sure? Normally systems shut down at 3.2V, 3V or so. Li-ion >> batteries don't >> really like to be discharged _this_ deep. > > You are correct. I'll fix it for the next version. > Looking into it further Sanyo and Panasonic get over 300 cycles bringing the NCR18650 down to 2.5V so 2.75V should be fine. http://www.batteryonestop.com/baotongusa/products/datasheets/li-ion/SANYO-NCR18650B-3400mAh.pdf https://industrial.panasonic.com/ww/products/batteries/secondary-batteries/lithium-ion/cylindrical-type/NCR18650PF Angus > Thanks > Angus > >> >> Pavel