From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Stone Zhang <quic_stonez@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_miaoqing@quicinc.com,
quic_zhichen@quicinc.com, quic_yuzha@quicinc.com
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride
Date: Tue, 18 Mar 2025 16:54:25 +0100 [thread overview]
Message-ID: <64ccc09d-7e1e-4c20-90e9-43b36a9cc46b@oss.qualcomm.com> (raw)
In-Reply-To: <20250318093350.2682132-3-quic_stonez@quicinc.com>
On 3/18/25 10:33 AM, Stone Zhang wrote:
> Enable WLAN on qcs8300-ride by adding a node for the PMU module
> of the WCN6855 and assigning its LDO power outputs to the existing
> WiFi module.
>
> Signed-off-by: Stone Zhang <quic_stonez@quicinc.com>
> ---
This change looks good generally, but please align the various stylistic
things, like property order in the nodes you add with x1e80100-crd.dtsi
I also see that board-2.bin doesn't contain the variant string you've
suggested ([1] @ commit 646e008ec53a8bb9ae16ebf98a65b29eaefd6da4)
Konrad
[1] https://git.codelinaro.org/clo/ath-firmware/ath11k-firmware/-/blob/main/WCN6855/hw2.0/board-2.bin?ref_type=heads
next prev parent reply other threads:[~2025-03-18 15:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 9:33 [PATCH v3 0/2] Enable WLAN for qcs8300-ride Stone Zhang
2025-03-18 9:33 ` [PATCH v3 1/2] arm64: dts: qcom: qcs8300: add a PCIe port for WLAN Stone Zhang
2025-03-18 15:48 ` Konrad Dybcio
2025-03-18 9:33 ` [PATCH v3 2/2] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride Stone Zhang
2025-03-18 15:54 ` Konrad Dybcio [this message]
2025-03-18 21:39 ` Dmitry Baryshkov
2025-03-19 4:21 ` Stone Zhang
2025-03-19 10:10 ` Dmitry Baryshkov
2025-03-19 10:13 ` Dmitry Baryshkov
2025-03-24 7:16 ` Stone Zhang
2025-03-18 17:07 ` [PATCH v3 0/2] Enable WLAN for qcs8300-ride Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64ccc09d-7e1e-4c20-90e9-43b36a9cc46b@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_miaoqing@quicinc.com \
--cc=quic_stonez@quicinc.com \
--cc=quic_yuzha@quicinc.com \
--cc=quic_zhichen@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®