From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: "Konstantin P." <ria.freelander@gmail.com>,
Andy Shevchenko <andy@kernel.org>
Cc: "Konstantin Pugin" <rilian.la.te@ya.ru>,
krzk@kernel.org, conor@kernel.org, lkp@intel.com, vz@mleia.com,
robh@kernel.org, jcmvbkbc@gmail.com, nicolas.ferre@microchip.com,
manikanta.guntupalli@amd.com, corbet@lwn.net,
ychuang3@nuvoton.com, u.kleine-koenig@pengutronix.de,
Maarten.Brock@sttls.nl,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Lech Perczak" <lech.perczak@camlingroup.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v6 1/3] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND
Date: Mon, 22 Apr 2024 16:06:49 +0200 [thread overview]
Message-ID: <64ce1c2e-4771-42d9-8ffe-9d03b09a61d2@gmx.de> (raw)
In-Reply-To: <CAF1WSuxPmzWYhCQU3tiA_GYMLowxMuvEJWRv83atithv8NCRxg@mail.gmail.com>
Hi,
On 22.04.24 15:20, Konstantin P. wrote:
> On Mon, Apr 22, 2024 at 3:56 PM Andy Shevchenko <andy@kernel.org> wrote:
>>
>> On Mon, Apr 22, 2024 at 03:37:55PM +0300, Konstantin Pugin wrote:
>>> From: Konstantin Pugin <ria.freelander@gmail.com>
>>>
>>> The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, but
>>> after the commit 4afeced55baa ("serial: core: fix sanitizing check for
>>> RTS settings") we always end up with SER_RS485_RTS_AFTER_SEND set and
>>> always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, which
>>> breaks some hardware using these chips.
>>
>> LGTM, but I leave it to Hugo for testing and other comments, if any,
>> as I don't have a HW.
>>
>> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>>
>>
>
> Andy, I need to do v7 (because there is a missed fix), but Yandex do
> not allow me to send more mail( So, can it be sent next day?
>
Please add at least the linux-serial mailing list the next time. As far as I am
concerned, I was only aware of this issue because of Andys response which added
linux-serial. Furthermore shouldnt this also got to stable?
Regards,
Lino
next prev parent reply other threads:[~2024-04-22 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 12:37 [PATCH v6 0/3] add support for EXAR XR20M1172 UART Konstantin Pugin
2024-04-22 12:37 ` [PATCH v6 1/3] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND Konstantin Pugin
2024-04-22 12:49 ` Andy Shevchenko
2024-04-22 13:20 ` Konstantin P.
2024-04-22 14:06 ` Lino Sanfilippo [this message]
2024-04-22 14:26 ` Andy Shevchenko
2024-04-22 12:37 ` [PATCH v6 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART Konstantin Pugin
2024-04-22 13:00 ` Krzysztof Kozlowski
2024-04-22 13:05 ` Konstantin P.
2024-04-22 12:37 ` [PATCH v6 3/3] serial: sc16is7xx: add support for EXAR " Konstantin Pugin
2024-04-22 12:51 ` Andy Shevchenko
2024-04-22 12:50 ` [PATCH v6 0/3] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64ce1c2e-4771-42d9-8ffe-9d03b09a61d2@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=Maarten.Brock@sttls.nl \
--cc=andy@kernel.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jcmvbkbc@gmail.com \
--cc=jirislaby@kernel.org \
--cc=krzk@kernel.org \
--cc=lech.perczak@camlingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=manikanta.guntupalli@amd.com \
--cc=nicolas.ferre@microchip.com \
--cc=ria.freelander@gmail.com \
--cc=rilian.la.te@ya.ru \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®