From: Dan Williams <dan.j.williams@intel.com>
To: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
<dan.j.williams@intel.com>
Cc: <vishal.l.verma@intel.com>, <dave.jiang@intel.com>,
<ira.weiny@intel.com>, <nvdimm@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <yusongping@huawei.com>,
<artem.kuzin@huawei.com>, <kjain@linux.ibm.com>,
<maddy@in.ibm.com>
Subject: RE: [PATCH] drivers: nvdimm: fix memleak
Date: Thu, 17 Aug 2023 08:06:15 -0700 [thread overview]
Message-ID: <64de3767e1245_29e22029456@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20230817115945.771826-1-konstantin.meskhidze@huawei.com>
[ add Kajol and Madhavan ]
Konstantin Meskhidze wrote:
> Memory pointed by 'nd_pmu->pmu.attr_groups' is allocated in function
> 'register_nvdimm_pmu' and is lost after 'kfree(nd_pmu)' call in function
> 'unregister_nvdimm_pmu'.
Yes, looks like a real issue, but also completely avoidable by using statically
defined groups.
My fault for not catching this earlier, but Kajol, why is nd_perf not using
statically defined sysfs attribute groups?
next prev parent reply other threads:[~2023-08-17 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 11:59 Konstantin Meskhidze
2023-08-17 14:32 ` Jeff Moyer
2023-08-17 15:06 ` Dan Williams [this message]
2023-08-17 16:00 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64de3767e1245_29e22029456@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=artem.kuzin@huawei.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=kjain@linux.ibm.com \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@in.ibm.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=yusongping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®