From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.160.174 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794712587; b=okcnJ5PjFCxI/iKGUriGofRe7vgiTbVXewY/z+trkT+K7kj2fns6xCnk/EFjIJkiadE+ cqQ+55ELBTvIb/M1iUmjlCH5JscMr7tFa5qk1fZtx9Y+oe1M1CNaPofKyVKXSB/UBBpHe 9LX0vfVSJxPqYbvJY4pP2NjidUxd/snwtQ3PdtGfDHpwLcTfJTzlY847sZK3UhIjIQSaj Xp2qGfcbZDZIukateqd9pXHk93zaVpnIHl3XdCzx0aMEAVQouWzI2qLEScZe7lRab2kmy a7hpUa64eWPGA3DpG0hP56TiT89XlNjDYyiS3kTJVzVAC5LgGWzA81efAIPHP8Ihl4Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794712587; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=CcJ012d98pXUSkoe1frivs9auTK2SIP4GqFrJm7lBB0=; b=Qc4+EQqcPm6hj/tq9kkEZXT08mE8O2pzQB/MQ7fGHZdSmpAoH/d1y0+uEKL7UHJHeRsx spHKt8nQWIeETQfCDqMTaociOG8lc9eY3cX74zn5aJ891IRmQDpl0aViKbymB2WvBCG2F C3vYZucPNorCPWzRB04HfTFqC7T6p/mown4U0AOws54im+gRLUJhM7SkXr19l+qiXGCPF rq6QGHRp7oDmWqPoVB50lW2nR/KBGkOIQJHrB8X26NLnx4+i5Lf6d96x+oEZT3KV1K1Yz ANfB92rLW/Fh9fPBLFrKUstpRR7L1gayLwPEt9Lo+rXKxvGC8dZFnvNT/z5edLDifOA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=nDn0QXj2; arc=none smtp.remote-ip=209.85.160.174 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A282606A323 for ; Sun, 15 Nov 2026 03:16:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2A282606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=nDn0QXj2 Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-55c35262674so9126161cf.0 for ; Sat, 14 Nov 2026 19:16:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794712586; x=1795317386; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CcJ012d98pXUSkoe1frivs9auTK2SIP4GqFrJm7lBB0=; b=nDn0QXj28VQiPE4K98zv5Xh4Yjwm7t62UjfcLenYcqhOo5h0hOqiS5xRcIA+4og9N2 RQnaKdJY7YvgPODxmsSwlcrY5e5hmYdGYAcDU3VLp8O2fanyyBW03GWvOAseg3YKVdur kJfGd1SrZPthJUpnDRewkGPwhaYIaPPNTbbS56apxaAVCCfxkUMWfqQHbKpJT8YqXfv5 Mcyw0FRhIlWfUUIL+x+uCTrj/JwnpVeszdWxBl+iAw38yG/4doOmbb0ThJSXidy1DVyR TYVJLU/lLzVbaP8O7bmJVWScaD1ks1j524vQgyhJAKOpZjMA3R6pnDA3WPVQyVZEngmE gcQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794712586; x=1795317386; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CcJ012d98pXUSkoe1frivs9auTK2SIP4GqFrJm7lBB0=; b=RtSh1nc1BuGzFmOFeT1HEqhJfVovQO51nP6f7MWUmC1q0XcC/7+045pvOWGZhy0nW7 vYE0q9c5f1gIzHetfMHb+58OfJwAmL9hLTvENTrBFJWDvJVhVrExz7LfBy4CjssEGqgB NlubZYGvKRrMCHdg2mGjVV4UPTto2y2YFiIIMBG+Yrkhwp6e6eg3bkPjyLXUHGkkC8ZN Zul8MXz4Vc8HRzj28WZ6o6aV2N5L56Vs0ttksPAZju52i+DTBTQeKsmt7vcZ9Xj9pkyP f6b8iLtXKj8L8W8e/sSz6eUhVANpiqGEtY0V0RAprb4YOlE3vIA/fOwM17YNoZmRpxKf 8fIQ== X-Forwarded-Encrypted: i=1; AL+hErEVd+L04VgrAnFDRjGV42j1Cfyz2Kn1B1h2LnZRngrfLmXWFZprPnpmX8ghGz87yKuZ/u8+atOgl4rvkms=@vger.kernel.org X-Gm-Message-State: APuU4Z/BE1u9gWaZ57SyjMPRNJN+pXwsqRthKPnpVGjNQRIhLAhmdd1A LrnTdjmksiNoEKf71h9OkzXDmxhPn4cjxYH+4MouwLtQ/qyJFhnbVzuY X-Gm-Gg: AYBFou27aHxj+o10fc72NGBTsx4rVD1+o4Rt9SIksRtXAnXRV7Dvzpko47verM9YYK7 wpKaLZteBbkSDuXPEO2vXyyve9kNld8e43fNOAgN41Mahq2BHXTYBmeR70IeHQnw3g7Xe8//CUf ZdSX1dAPbDH93UISVZPFKTQISGRr6wfqWRjk4yEyLBRSyDTM0zCpfYZvHQAqQzPZRA4yqKvacbl wCI+Lk5PzigopTdTVeUlkqWu39XC5y+DuLiTe177FS3nQ8r7vLAELyTkc5RsCIDsxl0SByvU3UH bOQjfv6KYmmJMslO3LQo26RxvpeLqSMWTZhH7afvhRkr1PzPx7H15xuSCLDcTSRwj0qGV1VrHHM DXC//Lsctkim85W7TsLMbkrLku82OTyZ5zh8TmtcYW4pF5zuWazJ92Q/lnNBEjisjl7xR3N55JM L7pdj5VvS9ZUNLq5UgwomhIzJDvqDEAW+RcsLo4mw4uSdh4i/uNDkDgKFqtPNufFjEcxTL8/u8w AmXPj7N9L+TsIEYg0ple5t3YG9aJva2uTVg9ZKqKptBGnPRTUmtZngS4UHVJzL+xmDnvIQSSFO2 GjuUr1IDcSoz/XPxRbOLAC6QCtwFRa5mPjn7E8r+xKrIwNSMLjU8ohTojnm9fmjvTQ1K40gm7z0 1SqYKIX4Z5Fc/tg2OICy4CvwDRrVX1p0/GFUpgUuqkcey1UMMrucgrQ== X-Received: by 2002:a05:622a:451:b0:55d:13c7:c232 with SMTP id d75a77b69052e-55d13c7c737mr38400571cf.51.1794712585934; Sat, 14 Nov 2026 19:16:25 -0800 (PST) Received: from ?IPV6:2600:4040:5abf:f200::9dd? ([2600:4040:5abf:f200::9dd]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-55ad1b13917sm52366751cf.29.2026.11.14.19.16.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Nov 2026 19:16:24 -0800 (PST) Message-ID: <64e7afd3-50e5-4134-9bf6-92c4aa740bd7@gmail.com> Date: Sat, 14 Nov 2026 22:16:23 -0500 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X To: Val Packett , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Maximilian Luz , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Alexandre Belloni , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org References: <20261104070441.74127-1-val@packett.cool> <20261104070441.74127-3-val@packett.cool> Content-Language: en-US From: Haipeng Lin In-Reply-To: <20261104070441.74127-3-val@packett.cool> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/4/26 2:04 AM, Val Packett wrote: > From: Maximilian Luz > > Introduce a device tree for the Surface Pro X tablet in all 3 variants > (SQ1 with cellular, SQ1 Wi-Fi only, SQ2 with cellular). [...] I believe there is also a Wi-Fi only SQ2 variant. Looking at the WoA drivers for 8180_CAS (Caspar, Wi-Fi only) https://github.com/WOA-Project/Qualcomm-Reference-Drivers/tree/master/Surface/8180_CAS/200.0.31.0 This variant is the only that has both SurfaceSMF_SQ1.cab and SurfaceSMF_SQ2.cab. Only 8180_CAS MPSS INF maps the no-modem subsystem ID (SUBSYS_MSNM8180 -> qcmpss8180_nm.mbn), the 8180_CAR (Carina) only lists the cellular MSWW/MSJP/MSCN IDs. My SQ2 Wi-Fi boots with the caspar dts in this patch fine but the gold cluster is pinned at SQ1's top clocks because the 3.072 / 3.1488 GHz OPPs are only in carina.dts. > diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts > new file mode 100644 > index 000000000000..5d155c69907a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts > @@ -0,0 +1,50 @@ > +// SPDX-License-Identifier: BSD-3-Clause > + > +/dts-v1/; > + > +#include "sc8180x-microsoft-surface-pro-x.dtsi" > + > +/ { > + model = "Microsoft Surface Pro X (SQ2)"; > + compatible = "microsoft,carina", "qcom,sc8180x"; > +}; > + > +&cpu4_opp_table { > + opp-3072000000 { > + opp-hz = /bits/ 64 <3072000000>; > + opp-peak-kBps = <8368000 51609600>; > + }; > + > + opp-3148800000 { > + opp-hz = /bits/ 64 <3148800000>; > + opp-peak-kBps = <8368000 51609600>; > + }; > +}; > + [...] Would it make sense to move opp-3072000000 and opp-3148800000 into the shared sc8180x-microsoft-surface-pro-x.dtsi? qcom-cpufreq-hw disables all DT OPPs first and only re-enables freqs present in the hardware LUT so this would work for SQ1 and caspar.dtb will cover both the SQ1 and SQ2 Wi-Fi models out of the box and carina.dts won't need its own &cpu4_opp_table override. > diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi > new file mode 100644 > index 000000000000..17fb01c6b164 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi [...] > +&smb2351_2 { > + status = "disabled"; > +}; > + > +&smb2351_a { > + status = "disabled"; > +}; Confirmed on hardware that labeling pmic@2 and pmic@a in sc8180x-pmics.dtsi fixes the dtc build failure here. [...]> +&uart13 { > + pinctrl-0 = <&uart13_state>; > + pinctrl-names = "default"; > + > + status = "okay"; [...] On linux-surface, ad1bb617a15a from Maximilian Luz had &qupv3_id_2 { status = "okay"; }; Would it be helpful to add here? I confirmed on hardware that adding it allows uart13 (WCN3998 Bluetooth) and uart15 (SAM EC) to populate and probe properly. Thanks, Haipeng