From: Randy Dunlap <rdunlap@infradead.org>
To: Yang Li <yang.lee@linux.alibaba.com>, anton@tuxera.com
Cc: linux-ntfs-dev@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>,
akpm@linux-foundation.org
Subject: Re: [PATCH -next] NTFS: Fix one kernel-doc comment
Date: Wed, 5 Jan 2022 18:01:49 -0800 [thread overview]
Message-ID: <64e8bd65-4801-4e09-3c35-03e3ff73c094@infradead.org> (raw)
In-Reply-To: <20220106015145.67067-1-yang.lee@linux.alibaba.com>
On 1/5/22 17:51, Yang Li wrote:
> /**
> * attrib.c - NTFS attribute operations. Part of the Linux-NTFS
>
> The comments for the file should not be in kernel-doc format, which causes
> it to be incorrectly identified for function ntfs_map_runlist_nolock(),
> causing some warnings found by running scripts/kernel-doc.
>
> fs/ntfs/attrib.c:25: warning: Incorrect use of kernel-doc format: *
> ntfs_map_runlist_nolock - map (a part of) a runlist of an ntfs inode
> fs/ntfs/attrib.c:71: warning: Function parameter or member 'ni' not
> described in 'ntfs_map_runlist_nolock'
> fs/ntfs/attrib.c:71: warning: Function parameter or member 'vcn' not
> described in 'ntfs_map_runlist_nolock'
> fs/ntfs/attrib.c:71: warning: Function parameter or member 'ctx' not
> described in 'ntfs_map_runlist_nolock'
> fs/ntfs/attrib.c:71: warning: expecting prototype for attrib.c - NTFS
> attribute operations. Part of the Linux(). Prototype was for
> ntfs_map_runlist_nolock() instead
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
[adding akpm]
> ---
> fs/ntfs/attrib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
> index d563abc3e136..2911c04a33e0 100644
> --- a/fs/ntfs/attrib.c
> +++ b/fs/ntfs/attrib.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> -/**
> +/*
> * attrib.c - NTFS attribute operations. Part of the Linux-NTFS project.
> *
> * Copyright (c) 2001-2012 Anton Altaparmakov and Tuxera Inc.
--
~Randy
prev parent reply other threads:[~2022-01-06 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 1:51 Yang Li
2022-01-06 2:01 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64e8bd65-4801-4e09-3c35-03e3ff73c094@infradead.org \
--to=rdunlap@infradead.org \
--cc=abaci@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=anton@tuxera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®