mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rohit Jain <rohit.k.jain@oracle.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: matt@codeblueprint.co.uk, mingo@kernel.org,
	dhaval.giani@oracle.com, subhra.mazumdar@oracle.com,
	steven.sistare@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC] sched: Distinguish between idle_cpu calls based on desired effect
Date: Wed, 9 May 2018 09:34:57 -0700	[thread overview]
Message-ID: <64ec7411-8d88-5531-72e2-8ac69f163b76@oracle.com> (raw)
In-Reply-To: <20180509085105.GG12217@hirez.programming.kicks-ass.net>

Hi Peter,


On 05/09/2018 01:51 AM, Peter Zijlstra wrote:
> On Mon, May 07, 2018 at 04:41:17PM -0700, Rohit Jain wrote:
>> In commit 247f2f6f3c706b40b5f3886646f3eb53671258bf we distinguish
>> between idle_cpu when the vcpu is not running for scheduling threads.
>> However, idle_cpu function is used at other places for actually checking
>> whether the state of the CPU is idle or not. Hence splitting the use of
>> that function based on the desired return value.
> Yes, that looks OK.

Great! Let me change the comment and send out v2.

>
> for your gitconfig:
>
> [core]
> 	abbrev = 12
> [alias]
>          one = show -s --pretty='format:%h (\"%s\")'
>
> $ git one 247f2f6f3c706b40b5f3886646f3eb53671258bf
> 247f2f6f3c70 ("sched/core: Don't schedule threads on pre-empted vCPUs")
>
> which gives the normal commit quote style.
>

Thanks! updated :)

Regards,
Rohit

      reply	other threads:[~2018-05-09 16:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 23:41 Rohit Jain
2018-05-08  0:15 ` Randy Dunlap
2018-05-08 17:03   ` Rohit Jain
2018-05-09  8:51 ` Peter Zijlstra
2018-05-09 16:34   ` Rohit Jain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64ec7411-8d88-5531-72e2-8ac69f163b76@oracle.com \
    --to=rohit.k.jain@oracle.com \
    --cc=dhaval.giani@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=steven.sistare@oracle.com \
    --cc=subhra.mazumdar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®