From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F3147ACEF for ; Thu, 8 Oct 2026 09:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791452429; cv=none; b=d4xGvawbFEidaV7wZXANZJViSxrQTdOZxX/pFfU2QlyUUtbN51w61vhQFho5qh+dWgN74BvZLUXe4IBAFKtA4DgrMix5EpkSlhib/LexWSFvBBXUj7AugzsvGt9K7COdFriil/cbXjeXU301ZmKRkUsNTykisH47Kiwf5ffa2Os= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791452429; c=relaxed/simple; bh=58b2zrPH8iIhN8iL5heRd06Xh/jVdffOwMLECL794hA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=LSU93jJi7u2IRZ+k98Ff7SG4LLTL/rLqYdo53CG2ZWAqHV/C7nDnvZPw6E4GkStsGkCkameAk0RDn2fD1NETWgd2ix/58b1bjB7FUMe3Wui6XAJcSiayY1P0kQx+P+3WtRx1URqYZCvKs99eGjXGOTijmoaMRw1fA2WShSLYJrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=Xj/4BLss; arc=none smtp.client-ip=210.118.77.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="Xj/4BLss" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20261008094019euoutp02a1f9536cf2481f341dfff0041e605142~chHvPofFw2290922909euoutp02u for ; Thu, 8 Oct 2026 09:40:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20261008094019euoutp02a1f9536cf2481f341dfff0041e605142~chHvPofFw2290922909euoutp02u DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1791452419; bh=WhxT/iYEf+0IDdqAC+j4Mz33sgpEH4FLr8IpDqOPvHM=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=Xj/4BLsstGZmeWUwb6NBvnlQo/AKu5++jt+G4Hx9BEvaGZSsa4hKAdMuJvMa1tZ0R 2MSNHUNKDRCtcRZ/tahQx62vBHZSEdLkJvZ0o8zCEy1FbJ3Ucqsnncd8tgGawaKBOh e39Lk7J/Gb5tWs8wpIQFsa+8xOidSA0J71GZW3B8= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20261008094018eucas1p2a59fec3fd358519ec23caaf4c8520660~chHunjtZg1919819198eucas1p2V; Thu, 8 Oct 2026 09:40:18 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20261008094018eusmtip23e01038e25862720727ab89e88db890c~chHuQeYBt1109211092eusmtip2O; Thu, 8 Oct 2026 09:40:17 +0000 (GMT) Message-ID: <64f7ea95-516f-4b95-a42e-14fd606879f9@samsung.com> Date: Thu, 8 Oct 2026 11:40:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH v1] Revert "drm/virtio: Add pixel blend mode property to cursor plane" To: Dmitry Osipenko , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu Cc: dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 7bit X-CMS-MailID: 20261008094018eucas1p2a59fec3fd358519ec23caaf4c8520660 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20261008093604eucas1p1857ec36ab7da379e75cb5f8bb993b1b6 X-EPHeader: CA X-CMS-RootMailID: 20261008093604eucas1p1857ec36ab7da379e75cb5f8bb993b1b6 References: <20261007222244.295186-1-dmitry.osipenko@collabora.com> On 08.10.2026 11:35, Dmitry Osipenko wrote: > On 10/8/26 01:22, Dmitry Osipenko wrote: >> The cursor blending mode was added twice because the same change was >> applied by accident from different patches. Revert the second patch. >> >> Reported-by: Marek Szyprowski >> Link: https://lore.kernel.org/dri-devel/ce84d3d2-e78b-4939-aecf-9ef7267bd42a@samsung.com/ >> Fixes: 6947b78df4d2 ("drm/virtio: Add pixel blend mode property to cursor plane") >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/gpu/drm/virtio/virtgpu_plane.c | 13 ------------- >> 1 file changed, 13 deletions(-) >> >> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c >> index b422eba42a5f..640815af4098 100644 >> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c >> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c >> @@ -589,7 +589,6 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev, >> struct drm_plane *plane; >> const uint32_t *formats; >> int nformats; >> - int ret; >> >> if (type == DRM_PLANE_TYPE_CURSOR) { >> formats = virtio_gpu_cursor_formats; >> @@ -615,17 +614,5 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev, >> drm_plane_create_blend_mode_property(plane, >> BIT(DRM_MODE_BLEND_PREMULTI)); >> >> - if (type == DRM_PLANE_TYPE_CURSOR) { >> - /* >> - * The cursor plane exposes a format with an alpha channel, >> - * which requires a blend mode property. The host blends >> - * premultiplied alpha, matching the property's default. >> - */ >> - ret = drm_plane_create_blend_mode_property(plane, >> - BIT(DRM_MODE_BLEND_PREMULTI)); >> - if (ret) >> - return ERR_PTR(ret); >> - } >> - >> return plane; >> } > Marek, could you please give your r-b? Reviewed-by: Marek Szyprowski Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland