mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ding Hui <dinghui@sangfor.com.cn>
To: Michal Kubiak <michal.kubiak@intel.com>, anthony.l.nguyen@intel.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,
	jesse.brandeburg@intel.com, keescook@chromium.org,
	grzegorzx.szczurek@intel.com, mateusz.palczewski@intel.com,
	mitch.a.williams@intel.com, gregory.v.rose@intel.com,
	jeffrey.t.kirsher@intel.com, simon.horman@corigine.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org, pengdonglin@sangfor.com.cn,
	huangcun@sangfor.com.cn
Subject: Re: [PATCH net v2 1/2] iavf: Fix use-after-free in free_netdev
Date: Thu, 27 Apr 2023 09:14:43 +0800	[thread overview]
Message-ID: <650acda0-9ec9-7634-3e01-e4870c8890b7@sangfor.com.cn> (raw)
In-Reply-To: <ZElExd5bAL2FCpIB@localhost.localdomain>

On 2023/4/26 23:35, Michal Kubiak wrote:
> On Wed, Apr 19, 2023 at 11:07:08PM +0800, Ding Hui wrote:
>> Cc: Huang Cun <huangcun@sangfor.com.cn>
>> Acked-by: Michal Kubiak <michal.kubiak@intel.com>
> 
> I'm sorry, but I don't remember giving "Acked-by" tag for that patch.
> I gave "Reviewed-by" only for the v2 series.
> 

Sorry, that is added by myself since your reply for v1 "Looks OK to me"
and "Looks correct to me", and I tried to ask for your agreement.

> We can't add any tags if they weren't given by the person himself.

I apologize to you.

> Please fix that.

Hi Tony Nguyen,
the patches is already applied to your dev-queue branch, should I send
v3 or you can fix it in your git?

> Nacked-by: Michal Kubiak <michal.kubiak@intel.com>
> 
>> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>> ---
>> v1 to v2:
>>    - add Fixes: tag
>>    - add reproduction script
>>    - update commit message
>>
>> ---
>>   drivers/net/ethernet/intel/iavf/iavf_main.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> -- 
>> 2.17.1
>>
> 

-- 
Thanks,
- Ding Hui


  reply	other threads:[~2023-04-27  1:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 15:07 [PATCH net v2 0/2] iavf: Fix issues when setting channels concurrency with removing Ding Hui
2023-04-19 15:07 ` [PATCH net v2 1/2] iavf: Fix use-after-free in free_netdev Ding Hui
2023-04-21 17:58   ` [Intel-wired-lan] " Chittim, Madhu
2023-04-26 15:35   ` Michal Kubiak
2023-04-27  1:14     ` Ding Hui [this message]
2023-04-28 16:41       ` Tony Nguyen
2023-04-19 15:07 ` [PATCH net v2 2/2] iavf: Fix out-of-bounds when setting channels on remove Ding Hui
2023-04-19 17:03   ` Simon Horman
2023-04-20 15:56 ` [PATCH net v2 0/2] iavf: Fix issues when setting channels concurrency with removing Michal Kubiak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=650acda0-9ec9-7634-3e01-e4870c8890b7@sangfor.com.cn \
    --to=dinghui@sangfor.com.cn \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregory.v.rose@intel.com \
    --cc=grzegorzx.szczurek@intel.com \
    --cc=huangcun@sangfor.com.cn \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mateusz.palczewski@intel.com \
    --cc=michal.kubiak@intel.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pengdonglin@sangfor.com.cn \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®