mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	 Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 kernel@pengutronix.de
Subject: Re: [PATCH 1/2] drm/panel: ilitek-ili9881c: Explicitly set address mode, allow 180° rotation
Date: Tue, 08 Oct 2024 11:07:31 +0200	[thread overview]
Message-ID: <650b56918dafbbf6cb07487b58fdfdf1ee9f48db.camel@pengutronix.de> (raw)
In-Reply-To: <20240626-drm-panel-ili9881c-rotation-v1-1-e0ff54173e32@pengutronix.de>

On Mi, 2024-06-26 at 16:40 +0200, Philipp Zabel wrote:
> We can use horizontal and vertical flipping via the MIPI DCS address
> mode to rotate the display by 180° using the device tree "rotation"
> property. Since the tl050hdv35 panel has been defined as rotated,
> we have to invert the bits there.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Gentle ping, this still cleanly applies on drm-misc-next.

> ---
>  drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index 084c37fa7348..b4565ff1a0de 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -42,6 +42,7 @@ struct ili9881c_desc {
>  	const size_t init_length;
>  	const struct drm_display_mode *mode;
>  	const unsigned long mode_flags;
> +	u8 default_address_mode;
>  };
>  
>  struct ili9881c {
> @@ -53,6 +54,7 @@ struct ili9881c {
>  	struct gpio_desc	*reset;
>  
>  	enum drm_panel_orientation	orientation;
> +	u8 address_mode;
>  };
>  
>  #define ILI9881C_SWITCH_PAGE_INSTR(_page)	\
> @@ -815,8 +817,6 @@ static const struct ili9881c_instr tl050hdv35_init[] = {
>  	ILI9881C_COMMAND_INSTR(0xd1, 0x4b),
>  	ILI9881C_COMMAND_INSTR(0xd2, 0x60),
>  	ILI9881C_COMMAND_INSTR(0xd3, 0x39),
> -	ILI9881C_SWITCH_PAGE_INSTR(0),
> -	ILI9881C_COMMAND_INSTR(0x36, 0x03),
>  };
>  
>  static const struct ili9881c_instr w552946ab_init[] = {
> @@ -1299,6 +1299,14 @@ static int ili9881c_prepare(struct drm_panel *panel)
>  	if (ret)
>  		return ret;
>  
> +	if (ctx->address_mode) {
> +		ret = mipi_dsi_dcs_write(ctx->dsi, MIPI_DCS_SET_ADDRESS_MODE,
> +					 &ctx->address_mode,
> +					 sizeof(ctx->address_mode));
> +		if (ret < 0)
> +			return ret;
> +	}
> +
>  	ret = mipi_dsi_dcs_set_tear_on(ctx->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
>  	if (ret)
>  		return ret;
> @@ -1521,6 +1529,12 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
>  		return ret;
>  	}
>  
> +	ctx->address_mode = ctx->desc->default_address_mode;
> +	if (ctx->orientation == DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP) {
> +		ctx->address_mode ^= 0x03;
> +		ctx->orientation = DRM_MODE_PANEL_ORIENTATION_NORMAL;
> +	}
> +

Is there anything wrong with the panel driver eating the bottom-up
panel orientation property by flipping scanout in the panel?

regards
Philipp

>  	ctx->panel.prepare_prev_first = true;
>  
>  	ret = drm_panel_of_backlight(&ctx->panel);
> @@ -1572,6 +1586,7 @@ static const struct ili9881c_desc tl050hdv35_desc = {
>  	.mode = &tl050hdv35_default_mode,
>  	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
>  		      MIPI_DSI_MODE_LPM,
> +	.default_address_mode = 0x03,
>  };
>  
>  static const struct ili9881c_desc w552946aba_desc = {
> 

  reply	other threads:[~2024-10-08  9:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 14:40 [PATCH 0/2] drm/panel: ilitek-ili9881c: Support in-panel " Philipp Zabel
2024-06-26 14:40 ` [PATCH 1/2] drm/panel: ilitek-ili9881c: Explicitly set address mode, allow " Philipp Zabel
2024-10-08  9:07   ` Philipp Zabel [this message]
2024-06-26 14:40 ` [PATCH 2/2] drm/panel: ilitek-ili9881c: Report subpixel order according to rotation Philipp Zabel
2024-10-09  7:47 ` [PATCH 0/2] drm/panel: ilitek-ili9881c: Support in-panel 180° rotation Neil Armstrong
2024-10-09  7:55 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=650b56918dafbbf6cb07487b58fdfdf1ee9f48db.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®