From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755365AbcLZKrR (ORCPT ); Mon, 26 Dec 2016 05:47:17 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:56653 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbcLZKrN (ORCPT ); Mon, 26 Dec 2016 05:47:13 -0500 Subject: Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup To: Alexander Koch , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org References: <20161223221205.8825-1-mail@alexanderkoch.net> <20161223221205.8825-4-mail@alexanderkoch.net> Cc: Rob Herring , Mark Rutland , Jean Delvare , Jiri Kosina From: Guenter Roeck Message-ID: <650d2371-57da-2494-7628-5a8bc5b756bf@roeck-us.net> Date: Mon, 26 Dec 2016 02:47:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161223221205.8825-4-mail@alexanderkoch.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/23/2016 02:12 PM, Alexander Koch wrote: > Replace sysfs symbolic file permissions, e.g. 'S_IRUGO', by octal > permissions. This fixes checkpatch.pl warnings. > > Signed-off-by: Alexander Koch Please do not bother with those warnings and ignore checkpatch. We are in the process of doing an automated conversion. Thanks, Guenter > --- > drivers/hwmon/adc128d818.c | 99 ++++++++++++++++++---------------------------- > 1 file changed, 39 insertions(+), 60 deletions(-) > > diff --git a/drivers/hwmon/adc128d818.c b/drivers/hwmon/adc128d818.c > index 8667f454ea11..cbb3bc5e5229 100644 > --- a/drivers/hwmon/adc128d818.c > +++ b/drivers/hwmon/adc128d818.c > @@ -242,69 +242,48 @@ static ssize_t adc128_show_alarm(struct device *dev, > return sprintf(buf, "%u\n", !!(alarms & mask)); > } > > -static SENSOR_DEVICE_ATTR_2(in0_input, S_IRUGO, > - adc128_show_in, NULL, 0, 0); > -static SENSOR_DEVICE_ATTR_2(in0_min, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 0, 1); > -static SENSOR_DEVICE_ATTR_2(in0_max, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 0, 2); > - > -static SENSOR_DEVICE_ATTR_2(in1_input, S_IRUGO, > - adc128_show_in, NULL, 1, 0); > -static SENSOR_DEVICE_ATTR_2(in1_min, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 1, 1); > -static SENSOR_DEVICE_ATTR_2(in1_max, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 1, 2); > - > -static SENSOR_DEVICE_ATTR_2(in2_input, S_IRUGO, > - adc128_show_in, NULL, 2, 0); > -static SENSOR_DEVICE_ATTR_2(in2_min, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 2, 1); > -static SENSOR_DEVICE_ATTR_2(in2_max, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 2, 2); > - > -static SENSOR_DEVICE_ATTR_2(in3_input, S_IRUGO, > - adc128_show_in, NULL, 3, 0); > -static SENSOR_DEVICE_ATTR_2(in3_min, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 3, 1); > -static SENSOR_DEVICE_ATTR_2(in3_max, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 3, 2); > - > -static SENSOR_DEVICE_ATTR_2(in4_input, S_IRUGO, > - adc128_show_in, NULL, 4, 0); > -static SENSOR_DEVICE_ATTR_2(in4_min, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 4, 1); > -static SENSOR_DEVICE_ATTR_2(in4_max, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 4, 2); > - > -static SENSOR_DEVICE_ATTR_2(in5_input, S_IRUGO, > - adc128_show_in, NULL, 5, 0); > -static SENSOR_DEVICE_ATTR_2(in5_min, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 5, 1); > -static SENSOR_DEVICE_ATTR_2(in5_max, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 5, 2); > - > -static SENSOR_DEVICE_ATTR_2(in6_input, S_IRUGO, > - adc128_show_in, NULL, 6, 0); > -static SENSOR_DEVICE_ATTR_2(in6_min, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 6, 1); > -static SENSOR_DEVICE_ATTR_2(in6_max, S_IWUSR | S_IRUGO, > - adc128_show_in, adc128_set_in, 6, 2); > - > -static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, adc128_show_temp, NULL, 0); > -static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, > +static SENSOR_DEVICE_ATTR_2(in0_input, 0444, adc128_show_in, NULL, 0, 0); > +static SENSOR_DEVICE_ATTR_2(in0_min, 0644, adc128_show_in, adc128_set_in, 0, 1); > +static SENSOR_DEVICE_ATTR_2(in0_max, 0644, adc128_show_in, adc128_set_in, 0, 2); > + > +static SENSOR_DEVICE_ATTR_2(in1_input, 0444, adc128_show_in, NULL, 1, 0); > +static SENSOR_DEVICE_ATTR_2(in1_min, 0644, adc128_show_in, adc128_set_in, 1, 1); > +static SENSOR_DEVICE_ATTR_2(in1_max, 0644, adc128_show_in, adc128_set_in, 1, 2); > + > +static SENSOR_DEVICE_ATTR_2(in2_input, 0444, adc128_show_in, NULL, 2, 0); > +static SENSOR_DEVICE_ATTR_2(in2_min, 0644, adc128_show_in, adc128_set_in, 2, 1); > +static SENSOR_DEVICE_ATTR_2(in2_max, 0644, adc128_show_in, adc128_set_in, 2, 2); > + > +static SENSOR_DEVICE_ATTR_2(in3_input, 0444, adc128_show_in, NULL, 3, 0); > +static SENSOR_DEVICE_ATTR_2(in3_min, 0644, adc128_show_in, adc128_set_in, 3, 1); > +static SENSOR_DEVICE_ATTR_2(in3_max, 0644, adc128_show_in, adc128_set_in, 3, 2); > + > +static SENSOR_DEVICE_ATTR_2(in4_input, 0444, adc128_show_in, NULL, 4, 0); > +static SENSOR_DEVICE_ATTR_2(in4_min, 0644, adc128_show_in, adc128_set_in, 4, 1); > +static SENSOR_DEVICE_ATTR_2(in4_max, 0644, adc128_show_in, adc128_set_in, 4, 2); > + > +static SENSOR_DEVICE_ATTR_2(in5_input, 0444, adc128_show_in, NULL, 5, 0); > +static SENSOR_DEVICE_ATTR_2(in5_min, 0644, adc128_show_in, adc128_set_in, 5, 1); > +static SENSOR_DEVICE_ATTR_2(in5_max, 0644, adc128_show_in, adc128_set_in, 5, 2); > + > +static SENSOR_DEVICE_ATTR_2(in6_input, 0444, adc128_show_in, NULL, 6, 0); > +static SENSOR_DEVICE_ATTR_2(in6_min, 0644, adc128_show_in, adc128_set_in, 6, 1); > +static SENSOR_DEVICE_ATTR_2(in6_max, 0644, adc128_show_in, adc128_set_in, 6, 2); > + > +static SENSOR_DEVICE_ATTR(temp1_input, 0444, adc128_show_temp, NULL, 0); > +static SENSOR_DEVICE_ATTR(temp1_max, 0644, > adc128_show_temp, adc128_set_temp, 1); > -static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO, > +static SENSOR_DEVICE_ATTR(temp1_max_hyst, 0644, > adc128_show_temp, adc128_set_temp, 2); > > -static SENSOR_DEVICE_ATTR(in0_alarm, S_IRUGO, adc128_show_alarm, NULL, 0); > -static SENSOR_DEVICE_ATTR(in1_alarm, S_IRUGO, adc128_show_alarm, NULL, 1); > -static SENSOR_DEVICE_ATTR(in2_alarm, S_IRUGO, adc128_show_alarm, NULL, 2); > -static SENSOR_DEVICE_ATTR(in3_alarm, S_IRUGO, adc128_show_alarm, NULL, 3); > -static SENSOR_DEVICE_ATTR(in4_alarm, S_IRUGO, adc128_show_alarm, NULL, 4); > -static SENSOR_DEVICE_ATTR(in5_alarm, S_IRUGO, adc128_show_alarm, NULL, 5); > -static SENSOR_DEVICE_ATTR(in6_alarm, S_IRUGO, adc128_show_alarm, NULL, 6); > -static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, adc128_show_alarm, NULL, 7); > +static SENSOR_DEVICE_ATTR(in0_alarm, 0444, adc128_show_alarm, NULL, 0); > +static SENSOR_DEVICE_ATTR(in1_alarm, 0444, adc128_show_alarm, NULL, 1); > +static SENSOR_DEVICE_ATTR(in2_alarm, 0444, adc128_show_alarm, NULL, 2); > +static SENSOR_DEVICE_ATTR(in3_alarm, 0444, adc128_show_alarm, NULL, 3); > +static SENSOR_DEVICE_ATTR(in4_alarm, 0444, adc128_show_alarm, NULL, 4); > +static SENSOR_DEVICE_ATTR(in5_alarm, 0444, adc128_show_alarm, NULL, 5); > +static SENSOR_DEVICE_ATTR(in6_alarm, 0444, adc128_show_alarm, NULL, 6); > +static SENSOR_DEVICE_ATTR(temp1_max_alarm, 0444, adc128_show_alarm, NULL, 7); > > static struct attribute *adc128_attrs[] = { > &sensor_dev_attr_in0_min.dev_attr.attr, >