From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA7B7C433FF for ; Mon, 12 Aug 2019 10:10:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B09AF20820 for ; Mon, 12 Aug 2019 10:10:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="OFqI8123" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbfHLKKE (ORCPT ); Mon, 12 Aug 2019 06:10:04 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:48496 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727323AbfHLKKE (ORCPT ); Mon, 12 Aug 2019 06:10:04 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x7CA9rhU091302; Mon, 12 Aug 2019 05:09:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1565604593; bh=UZRnkM5LvmQhJ973nCFgnIBPPkZUhy0vG2BKjcSREDU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=OFqI8123VtOzyplXQHgfAaDINyZGQx4DKU5ymPOs5iKWU9CWweRQ3lx4iK/hJFvmj 2lImSblZMp3Bs2oJbi2NRTR6RNNW8wko8EQ6l3cWCbZl9/4YBhusR3Xe60liZ4KCzU APpkW/AEHGXGSNqLl0kAjLQQhc4bAtrF1FlMjco4= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x7CA9rBb127011 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 12 Aug 2019 05:09:53 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 12 Aug 2019 05:09:52 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 12 Aug 2019 05:09:52 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x7CA9pfA058659; Mon, 12 Aug 2019 05:09:51 -0500 Subject: Re: [PATCH] dma: ti: unexport filter functions To: Arnd Bergmann , Vinod Koul CC: Stephen Rothwell , , References: <20190812093623.992757-1-arnd@arndb.de> From: Peter Ujfalusi Message-ID: <650d280a-a13e-ffa3-9c55-d235ed6c0b16@ti.com> Date: Mon, 12 Aug 2019 13:10:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190812093623.992757-1-arnd@arndb.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/08/2019 12.36, Arnd Bergmann wrote: > The two filter functions are now marked stable, but still exported, > which triggers a coming build-time check: > > WARNING: "omap_dma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL_GPL > WARNING: "edma_filter_fn" [vmlinux] is a static EXPORT_SYMBOL > > Remove the unneeded exports as well, as originally intended. > > Fixes: 9c71b9eb3cb2 ("dmaengine: omap-dma: make omap_dma_filter_fn private") > Fixes: d2bfe7b5d182 ("dmaengine: edma: make edma_filter_fn private") > Reported-by: Stephen Rothwell > Signed-off-by: Arnd Bergmann Acked-by: Peter Ujfalusi > --- > drivers/dma/ti/edma.c | 1 - > drivers/dma/ti/omap-dma.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c > index f2549ee3fb49..ea028388451a 100644 > --- a/drivers/dma/ti/edma.c > +++ b/drivers/dma/ti/edma.c > @@ -2540,7 +2540,6 @@ static bool edma_filter_fn(struct dma_chan *chan, void *param) > } > return match; > } > -EXPORT_SYMBOL(edma_filter_fn); > > static int edma_init(void) > { > diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c > index 49da402a1927..98b39bcb7b37 100644 > --- a/drivers/dma/ti/omap-dma.c > +++ b/drivers/dma/ti/omap-dma.c > @@ -1652,7 +1652,6 @@ static bool omap_dma_filter_fn(struct dma_chan *chan, void *param) > } > return false; > } > -EXPORT_SYMBOL_GPL(omap_dma_filter_fn); > > static int omap_dma_init(void) > { > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki