mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Akhil R <akhilrajeev@nvidia.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	thierry.reding@gmail.com, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node
Date: Fri, 13 May 2022 09:39:31 +0100	[thread overview]
Message-ID: <6510d8be-38a7-8470-d832-15b948671703@nvidia.com> (raw)
In-Reply-To: <36bb53d0-80b3-f79e-a599-6acb98d0c872@linaro.org>


On 13/05/2022 09:32, Krzysztof Kozlowski wrote:
> On 12/05/2022 11:00, Akhil R wrote:
>> Add device tree nodes for Tegra234 GPCDMA
>>
>> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
>> ---
>>   arch/arm64/boot/dts/nvidia/tegra234.dtsi | 43 ++++++++++++++++++++++++
>>   1 file changed, 43 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> index cb3af539e477..860c3cc68cea 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> @@ -21,6 +21,49 @@
>>   
>>   		ranges = <0x0 0x0 0x0 0x40000000>;
>>   
>> +		gpcdma: dma-controller@2600000 {
>> +			compatible = "nvidia,tegra194-gpcdma",
>> +				      "nvidia,tegra186-gpcdma";
>> +			reg = <0x2600000 0x210000>;
>> +			resets = <&bpmp TEGRA234_RESET_GPCDMA>;
>> +			reset-names = "gpcdma";
>> +			interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
>> +			#dma-cells = <1>;
>> +			iommus = <&smmu_niso0 TEGRA234_SID_GPCDMA>;
>> +			dma-coherent;
>> +			status = "okay";
> 
> okay is by default for new nodes.

Just so I know, is it recommended then to drop the status in this case 
or is it OK to leave as is?

Jon

-- 
nvpublic

  reply	other threads:[~2022-05-13  8:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12  9:00 [PATCH 0/2] Add GPCDMA support for Tegra234 Akhil R
2022-05-12  9:00 ` [PATCH 1/2] dt-bindings: Add headers for Tegra234 GPCDMA Akhil R
2022-05-13  8:32   ` Krzysztof Kozlowski
2022-05-12  9:00 ` [PATCH 2/2] arm64: tegra: Add Tegra234 GPCDMA device tree node Akhil R
2022-05-13  8:32   ` Krzysztof Kozlowski
2022-05-13  8:39     ` Jon Hunter [this message]
2022-05-13  9:14       ` Krzysztof Kozlowski
2022-05-12  9:09 ` [PATCH 0/2] Add GPCDMA support for Tegra234 Jon Hunter
2022-05-12  9:21   ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6510d8be-38a7-8470-d832-15b948671703@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=akhilrajeev@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®