From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938661AbcIGLfH (ORCPT ); Wed, 7 Sep 2016 07:35:07 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:52100 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933961AbcIGLfG (ORCPT ); Wed, 7 Sep 2016 07:35:06 -0400 From: Arnd Bergmann To: Felipe Balbi Cc: Greg Kroah-Hartman , Heikki Krogerus , John Youn , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH for v4.8] usb: dwc3: mark PM function as __maybe_unused Date: Wed, 07 Sep 2016 13:35:30 +0200 Message-ID: <6515314.rRh5qNlOdM@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <87a8fkkn8r.fsf@linux.intel.com> References: <20160906132318.2033811-1-arnd@arndb.de> <87a8fkkn8r.fsf@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:6Im9LhOG/0XbRbUlBMlcmsU3V8nEtVmHEDWZ+b2WfBytzI6r9DB ldLFC4670ox2foCY+YPQnrmLz5fukZfAqbPo6ANl7OsjNzoxZKQsKMosqsgWJrDyrTCDXcj kQg2J32ava23dmZQsPOAmdafNcX4tuGBN9epkcPd6esB6C16keWAxkM2RgQ+MC61x3/W4qh sEn20cyzWxk7z1kRKh03g== X-UI-Out-Filterresults: notjunk:1;V01:K0:MbaSS1gO9ow=:0Lie1rTpC4iqhd9yMmlXPh nZL9YUONhQPWgricsb+tWfVlq4r8WMLwLimQ0bhxDejsSoYpdcmKLByp5nKuOxHEZLTdro+4l VxQSgikpAuz2I2G7b0YVqqY4EQ8eugA2mW+70FQKvGo9Q7f9mdmQ09dVE5txd06k2+Go1rTN8 UAQEfSBN5qBW4dhrT7GJwgEFq1m8TF9MGUPkUXO2vWiIr9ivqFLhFOBXXi5SFl77gDQgaFNuz I60/K7KKeEFotNocnV3jnFyB3nWxgROJm2zaolKdDsbQj5Op9M2W3jN3Lq3lxBJSSrw96GGsE Q0CdlREbzVoTtW88GpXLHP3hOjPOnXrjbEXC6rhnJFh0Orcj+zvaSZYqqm9gq7a2EUo0QNcmV ADwGMdlyvM26HJdppGLbUQBKLAo935MjG5lPtnj3d4y6eGlsLefIu2VTCHhyiLSKRxJatNyHV OdlMbyxOwxGC7D4xvRa4gaOSccdjrsBAI0EtPwrTCbtfJyom1cKOIsxdJHDGpts3MooHS8EYZ 8j3cHPoqqeDgFgPHkY2JMJ/4uSAcllbFRfyOAziwlLPPwHLQD7LKAsaONPspOoK1eTcbdg2Qc 3Fg/UlxY+8kGqBIQZfQFCRmKQrGbe4OmQYHfxa9oD83wcm1dfONC2nh6aqqxxrwNshkpi1JxU BkeIjWVFN1UG7Cy+VqM7rMEym0YdR0jUzPj71cELMMg/fNI14kkO0SuNdFwaX+yIrkOVrH9vK Dm3J5EK5VXnMN1/a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 7, 2016 1:39:16 PM CEST Felipe Balbi wrote: > > seems like it would've been enough to define dwc3_pci_pm_dummy() if > CONFIG_PM_SLEEP. Right? IOW: > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > index 0a32430f4c41..6df0f5dad9a4 100644 > --- a/drivers/usb/dwc3/dwc3-pci.c > +++ b/drivers/usb/dwc3/dwc3-pci.c > @@ -249,7 +249,9 @@ static int dwc3_pci_runtime_resume(struct device *dev) > > return pm_runtime_get(&dwc3->dev); > } > +#endif /* CONFIG_PM */ > > +#ifdef CONFIG_PM_SLEEP > static int dwc3_pci_pm_dummy(struct device *dev) > { > /* > @@ -262,7 +264,7 @@ static int dwc3_pci_pm_dummy(struct device *dev) > */ > return 0; > } > -#endif /* CONFIG_PM */ > +#endif /* CONFIG_PM_SLEEP */ > > static struct dev_pm_ops dwc3_pci_dev_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(dwc3_pci_pm_dummy, dwc3_pci_pm_dummy) > > Can you check if this is enough for you? Works just fine here. > I'm sure this solves the problem too Acked-by: Arnd Bergmann I usually prefer the __maybe_unused annotation over the #ifdef because it's much harder to get wrong, but I'm really only interested in killing that last warning in the v4.8 kernel build at the moment ;-) I am getting a bit annoyed with seeing at least half a dozen such bugs every week (in linux-next) and I have an idea for how to replace SET_SYSTEM_SLEEP_PM_OPS() etc with something that doesn't need any #ifdef of __maybe_unused, but that is a bigger chunk of work that will require careful planning. Arnd