mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Chen Ni <nichen@iscas.ac.cn>
Cc: oss-drivers@corigine.com, netdev@vger.kernel.org,
	 linux-kernel@vger.kernel.org, louis.peens@corigine.com,
	kuba@kernel.org,  davem@davemloft.net, edumazet@google.com,
	horms@kernel.org,  yinjun.zhang@corigine.com,
	johannes.berg@intel.com, ryno.swart@corigine.com,
	 ziyang.chen@corigine.com, linma@zju.edu.cn,
	niklas.soderlund@corigine.com
Subject: Re: [PATCH net-next] ntp: fix size argument for kcalloc
Date: Thu, 04 Jul 2024 11:36:36 +0200	[thread overview]
Message-ID: <65153ac3f432295a89b42c8b9de83fcabdefe19c.camel@redhat.com> (raw)
In-Reply-To: <5cafbf6e-37ad-4792-963e-568bcc20640d@intel.com>

On Wed, 2024-07-03 at 11:16 +0200, Przemek Kitszel wrote:
> On 7/3/24 04:56, Chen Ni wrote:
> > The size argument to kcalloc should be the size of desired structure,
> 
> xsk_pools is a double pointer, so not "desired structure" but rather you
> should talk about an element size.
> 
> > not the pointer to it.
> > 
> > Fixes: 6402528b7a0b ("nfp: xsk: add AF_XDP zero-copy Rx and Tx support")
> 
> even if the the behavior is not changed, the fix should be targeted to
> net tree

This patch is IMHO more a cleanup than a real fix. As such it's more
suited for net-next. For the same reason I think it should not go to
stable, so I'm dropping the fixes tag, too.

Thanks,

Paolo


  reply	other threads:[~2024-07-04  9:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03  2:56 Chen Ni
2024-07-03  9:16 ` Przemek Kitszel
2024-07-04  9:36   ` Paolo Abeni [this message]
2024-07-04  9:41     ` Paolo Abeni
2024-07-04 10:17       ` Przemek Kitszel
2024-07-04 14:21         ` Jakub Kicinski
2024-07-04  5:36 ` Louis Peens
2024-07-04  7:30 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65153ac3f432295a89b42c8b9de83fcabdefe19c.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=johannes.berg@intel.com \
    --cc=kuba@kernel.org \
    --cc=linma@zju.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.peens@corigine.com \
    --cc=netdev@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=ryno.swart@corigine.com \
    --cc=yinjun.zhang@corigine.com \
    --cc=ziyang.chen@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®