From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754358AbdCPVrJ (ORCPT ); Thu, 16 Mar 2017 17:47:09 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:55163 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754297AbdCPVrG (ORCPT ); Thu, 16 Mar 2017 17:47:06 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Vignesh R , Greg Kroah-Hartman , Jisheng Zhang , linux-kernel@vger.kernel.org, Andy Shevchenko , linux-serial@vger.kernel.org, Jiri Slaby Subject: Re: [PATCH] serial: 8250: 8250_core: Fix irq name for 8250 serial irq Date: Thu, 16 Mar 2017 22:46:06 +0100 Message-ID: <6515939.2USCG1AhyO@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.8.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20170316122653.19930-1-vigneshr@ti.com> References: <20170316122653.19930-1-vigneshr@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:GVvZCTcUSdQbCByh4XKhjO9TC/tMqbAoGMP0CqHEuGNujccX8sL aH94DeTqKfu5Zk9vQeaFP5xmhOMGXfnzSwSXKL7sii5DI9nEYHxRPq6OYhA2ddvSsl7uE+g 7VD2D8vLzh7STawcd1xpK4ct82wEPFEfm5sMjINl3ZG0Jo8ViWSieMJAzOI0O2VSfhaFHcb 0JJitvsO74aOjh/zCsLmQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:36d5/Xf9MFk=:mFfRhuO7HSpuP5p3EaOCqC in6cEhrDbn+iduuyEYzM1C1hklDi8+uJSd6+0zwcVE8MPknmNrShUF90a4auFVBoRAcjG2a84 WDcZADHGwuRll9ZmQGocJvbpjCRJjU+QFjYWWscabAp7/fsGGO8xjIqvUVMgnuof51aIbg9uR JDxnBVSrxvOLUsrPmDs0S+LyTP/9m4GZMHeqeI4SrpM4olkiVQY7feZxtxztY6ox0axabPSgK M4BznX4SPDy8ujSKCs0rbvMf/X7C6iHL04dsP6O50Idr9xsjAW5VCZ++65UD+9ZdXI5/AmtWo gz4inNZgUFJbNxOdYbNAECnzynB7Tt0il8F95aOm4G3YzpkyIRYKbUph2MFvJARSJ2T2HreCq cyUlTkRDYXXYOLYDRdTs7pzMwCQ+yecs54UcVP2KprLPF3zVLA5HUQRHZVu23cpmO55QNcfk+ jgzt0nrljNPmATxL2WRZtmBV1z5EzJ9zcXJUSUziLIyyJWr3lQ+kno0t1FCV/55QngyOqJKUB f270370VO76MZJwLgn2+Z9CmAY9HyyONjSQmvRdRcnu+K4uN3pI7ZzIBtNIkMTA2ftgsqf3cW LKbFRh3PrINQebMuFxlnqqf8PkJMr/ClkDKC1O5P1+shxlu5vErh5j8rP82WAWblY42esYhkn nMvzxyYwAywIoeVoT3Xlp7DknMegmWPjv3hodTDnoiQzMiWiVDpCHdIq6xnXm3tZ8PH7acmrv e0WR12g2HiUa/8fg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, March 16, 2017 5:56:53 PM CET Vignesh R wrote: > Using dev_name() as irq name during request_irq() might be misleading in > case of serial over PCI. Therefore use a better alternative name for > identifying serial port irqs as "serial" appended with serial_index of > the port. This ensures that "serial" string is always present in irq > name while port index will help in distinguishing b/w different ports. > > Signed-off-by: Vignesh R > --- > > Based on top of tty-next. > > drivers/tty/serial/8250/8250_core.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c > index f83b69f30987..78bf621d6827 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -213,12 +213,20 @@ static int serial_link_irq_chain(struct uart_8250_port *up) > > ret = 0; > } else { > + char *irqname = kmalloc(20, GFP_KERNEL); > + if (!irqname) { > + spin_unlock_irq(&i->lock); > + return -ENOMEM; > + } > + snprintf(irqname, 20, > + "serial%d", serial_index(&up->port)); kasprintf()? Also, you need to free the memory after free_irq(). Arnd