From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbbCKVoa (ORCPT ); Wed, 11 Mar 2015 17:44:30 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:51225 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751437AbbCKVo0 (ORCPT ); Wed, 11 Mar 2015 17:44:26 -0400 From: "Rafael J. Wysocki" To: Eric Anholt , Kevin Hilman , Ulf Hansson Cc: linux-kernel@vger.kernel.org, Tomasz Figa , Greg Kroah-Hartman , Linux PM list Subject: Re: [PATCH] PM / Domains: If an OF node is found but no device probed yet, defer. Date: Wed, 11 Mar 2015 23:08:11 +0100 Message-ID: <6516096.HanqZ05BXy@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1426087648-3862-1-git-send-email-eric@anholt.net> References: <1426087648-3862-1-git-send-email-eric@anholt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org More CCes. On Wednesday, March 11, 2015 08:27:28 AM Eric Anholt wrote: > If we've declared a power domain in the OF, and the OF node is found > but the requested domain hasn't been registered on it yet, then we > probably have just tried to probe before the power domain driver has. > Defer our device's probe until it shows up. > > Signed-off-by: Eric Anholt Kevin, Ulf, any chance to have a look at this, please? > --- > > I ran into this when turning my ad-hoc code for BCM2835 (Raspberry Pi) > USB poweron support in the DWC2 controller to an OF-based power domain > declaration. > > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index ba4abbe..2b93c98 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2064,7 +2064,7 @@ EXPORT_SYMBOL_GPL(of_genpd_del_provider); > struct generic_pm_domain *of_genpd_get_from_provider( > struct of_phandle_args *genpdspec) > { > - struct generic_pm_domain *genpd = ERR_PTR(-ENOENT); > + struct generic_pm_domain *genpd = ERR_PTR(-EPROBE_DEFER); > struct of_genpd_provider *provider; > > mutex_lock(&of_genpd_mutex); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.