From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932406AbcIUHtn (ORCPT ); Wed, 21 Sep 2016 03:49:43 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:59646 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbcIUHtk (ORCPT ); Wed, 21 Sep 2016 03:49:40 -0400 Subject: Re: [PATCH net-next 8/8] net: qualcomm: add QCA7000 UART driver To: Marcel Holtmann References: <1474376544-20515-1-git-send-email-stefan.wahren@i2se.com> <1474376544-20515-9-git-send-email-stefan.wahren@i2se.com> <2EE064FD-FCC1-4559-819D-471BD000F5AF@holtmann.org> Cc: "David S. Miller" , Greg Kroah-Hartman , Jiri Slaby , Network Development , LKML , Rob Herring From: Stefan Wahren Message-ID: <6516862d-9703-5a61-16f5-e363c8e370cb@i2se.com> Date: Wed, 21 Sep 2016 09:49:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <2EE064FD-FCC1-4559-819D-471BD000F5AF@holtmann.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:G0aRQcLWTLo2uXOrIEv0kJneTaw2z31HjuzHv5o3+PH8WckxfNa Q3lnF47EUex5FV4d5f0YQm3g8bzCCuFW1b0koSgA8bl3zaBqcj+14wIusDYWtPNjxpj6Z5Z a7nLvwbefAER44KkyWT0C/eN6BG6DPoKkgTtwxLWE+UxuFp0tjkCC9LNRaRO4Mf21kJ4/z+ nFFVoPINBlpuUAvDav7QQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:/UxWFVnaLG0=:eP/LnxDUiTy4OUVrJAuAv3 cEbFDh4eZzZzxhMQpEMuF1dGjvWp1RxQrwuuTM8CWGuCK/NGjoD7vqtHV+6BGsMc4lUxK4SKx iAbkUZ7Dr4a0MPN1RMJS8WVprroXgb8PPC/Te4NbRfQQQ/1fvSZ+E5RKQ4sRJHuvKFRbbBf+R tWpR/lU6eQC42/m8vYDjGKIG5ysgLB0F8bmoeXe7rpsXdQL57LqmDAwwXdKuYFqp/ZvsEXg2y VLGBe6uaAeEiaeR7wlU3TfOAV8JUAhmV/dlqneKW+VXf/9K2UTv58jFEnQzRE4vlov9UPs09m UCRQUfo9klNyYAB6uoq60Wyzf9uewhuhvbZ+mHmzXHiGRsnbRXshHguiLow7vWyH0rnavMLz+ Xt+7oFq/jj83MVHyWfQs32gn7q7zAxOkd3xyd2I1uRiMI2h65H476hyyQpPVTe02bqAxROn8R qJPfhNAPOnz/14PdyuShj0qzhVgofGPdL/Q/0GTUQd725TC/3ZWmYroYE4PaaCtCSlljouAKF dveSvmr1hsbpiIQ688RoEsrKUYyas8wX4s/eJR1217rDti2g4sOX4HXV+TF0EuINP38JzB0T/ jP00M3XEHzIiSGtqXbh1KhppQE8edYwVNUFe9XTNAqL/5qSrXmDr97vZIzW/4+Q2SnU9ai2bE uzc453fZEjJwYWWGbo56dUUN2iumRF4yGMp18Y0jEqiu9RnP4B0mQcVzYWD0gKN05RwqcmaaV Kt5xWi3TWQ9LN/a/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marcel, Am 20.09.2016 um 17:32 schrieb Marcel Holtmann: > Hi Stefan, > >> This patch adds the Ethernet over UART driver for the >> Qualcomm QCA7000 HomePlug GreenPHY. >> >> Signed-off-by: Stefan Wahren >> --- >> drivers/net/ethernet/qualcomm/Kconfig | 12 + >> drivers/net/ethernet/qualcomm/Makefile | 2 + >> drivers/net/ethernet/qualcomm/qca_common.h | 6 + >> drivers/net/ethernet/qualcomm/qca_uart.c | 447 +++++++++++++++++++++++++++++ >> include/uapi/linux/tty.h | 1 + >> 5 files changed, 468 insertions(+) >> create mode 100644 drivers/net/ethernet/qualcomm/qca_uart.c >> >> diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig >> index 0d33728..0ede46e 100644 >> --- a/drivers/net/ethernet/qualcomm/Kconfig >> +++ b/drivers/net/ethernet/qualcomm/Kconfig >> @@ -30,6 +30,18 @@ config QCA7000_SPI >> To compile this driver as a module, choose M here. The module >> will be called qcaspi. >> >> +config QCA7000_UART >> + tristate "Qualcomm Atheros QCA7000 UART support" >> + select QCA7000 >> + depends on TTY >> + ---help--- >> + This UART protocol driver supports the Qualcomm Atheros QCA7000. >> + The driver implements the tty line discipline N_QCA7K and supports >> + only one netdevice. >> + >> + To compile this driver as a module, choose M here. The module >> + will be called qcauart. >> + > this seems to be another candidate for having a proper UART or serial bus. Instead of adding one line discipline after another, I think we need to get quickly to having an enumerable bus here. i noticed Rob's thread about the UART slave device bus and i like the idea. Stefan > > Regards > > Marcel >