From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
srinivas.kandagatla@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v3 1/2] dt-bindings: lan9662-otpc: document Lan9662 OTPC
Date: Wed, 31 Aug 2022 15:45:08 +0300 [thread overview]
Message-ID: <651930f2-37a6-4628-e232-880d41c0997c@linaro.org> (raw)
In-Reply-To: <20220831104455.2oc24fokicieyh37@soft-dev3-1.localhost>
On 31/08/2022 13:44, Horatiu Vultur wrote:
> The 08/31/2022 10:28, Krzysztof Kozlowski wrote:
>
> Hi Krzysztof,
>
>>> +
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - items:
>>> + - const: microchip,lan9662-otpc
>>> + - const: microchip,lan9668-otpc
>>> + - enum:
>>> + - microchip,lan9662-otpc
>>
>> This is not what I wrote and this does not make sense. You now listed
>> twice 9662 and 9668 does not have its entry.
>
> As you figured it out, I am quite noob at these bindings.
> The only difference between what you wrote and what I wrote is the order
> under items. So the order matters?
Yes, because it is not an enum but list. What you wrote is:
compatible = "microchip,lan9662-otpc", "microchip,lan9668-otpc"
and you would see the problems if you tested it with lan9668.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-31 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 6:42 [PATCH v3 0/2] nvmem: lan9662-otpc: add support Horatiu Vultur
2022-08-31 6:42 ` [PATCH v3 1/2] dt-bindings: lan9662-otpc: document Lan9662 OTPC Horatiu Vultur
2022-08-31 7:28 ` Krzysztof Kozlowski
2022-08-31 10:44 ` Horatiu Vultur
2022-08-31 12:45 ` Krzysztof Kozlowski [this message]
2022-08-31 6:42 ` [PATCH v3 2/2] nvmem: lan9662-otp: add support Horatiu Vultur
2022-08-31 7:29 ` Krzysztof Kozlowski
2022-08-31 10:52 ` Horatiu Vultur
2022-08-31 12:52 ` Krzysztof Kozlowski
2022-08-31 14:52 ` Horatiu Vultur
2022-08-31 15:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=651930f2-37a6-4628-e232-880d41c0997c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®